Open Bug 1403520 Opened 7 years ago Updated 2 years ago

Left tab misses separator if there's a button before the tabstrip

Categories

(Firefox :: Theme, defect, P4)

57 Branch
defect

Tracking

()

Tracking Status
firefox-esr52 --- unaffected
firefox59 --- wontfix
firefox60 --- fix-optional
firefox61 --- fix-optional

People

(Reporter: Gijs, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: polish, regression, ux-consistency, Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

Attached image Screenshot (deleted) —
STR: 1. clean profile, open firefox 2. open customize mode 3. move home button (or any button) in front of the tabstrip ER: left tab keeps having border, button maybe has a border to its left or maybe not AR: left tab border disappears, button has a left border This doesn't get fixed by leaving customize mode - the border just doesn't show up. This looks very odd.
Hm this is probably just the same as bug 1403498, but thanks for pointing out the button edge case. Should we dupe them?
(In reply to Johann Hofmann [:johannh] from comment #1) > Hm this is probably just the same as bug 1403498, but thanks for pointing > out the button edge case. Should we dupe them? I don't really understand how they're the same. It seems quite plausible, based on the fix for bug 1390025, that we'd want to fix this one by giving buttons in the tabstrip end-side/right-hand borders, which wouldn't fix 1403498. Likewise, we could fix that bug by given the inner scrollbox a start border, which wouldn't fix this bug.
Fair enough, let's keep them separate.
Flags: qe-verify+
Priority: -- → P3
QA Contact: ovidiu.boca
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Priority: P3 → P4
Let's do this after bug 1391539, otherwise we'll have to file another bug to adjust the height of this border when hovering (I'm happy to pick it up once bug 1391539 is done).
Depends on: 1391539
Depends on: 1403483
Bug #1391539 was fixed. Any plans for picking this up?
Flags: needinfo?(jhofmann)
No, we're still depending on bug 1403483 as well, which, uh, we should really try to fix at some point...
Flags: needinfo?(jhofmann)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: