Closed
Bug 1403610
Opened 7 years ago
Closed 7 years ago
update to source-map 0.6.0
Categories
(DevTools :: Framework, defect, P3)
DevTools
Framework
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file)
source-map 0.6.0 is released, so land a new bundle in devtools/shared/sourcemap
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8912754 [details]
Bug 1403610 - update to source-map 0.6.1;
https://reviewboard.mozilla.org/r/184066/#review189366
Attachment #8912754 -
Flags: review?(bgrinstead) → review+
|
Assignee | |
Comment 4•7 years ago
|
||
One test failure is buglet in the test case, but another will have to be solved upstream.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Also some minor changes to the server side were needed - I forgot about changing the
SourceMapConsumer invocations here. Once the upstream PR is in, I'll do a new release
and update this bug and re-request review.
https://github.com/mozilla/source-map/pull/289
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 7•7 years ago
|
||
Comment on attachment 8912754 [details]
Bug 1403610 - update to source-map 0.6.1;
I changed the actors to pass the new source map URL argument to the SourceMapConsumer constructor; and I fixed a corresponding buglet in one test. So, I think this requires a re-review.
Attachment #8912754 -
Flags: review+ → review?(bgrinstead)
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8912754 [details]
Bug 1403610 - update to source-map 0.6.1;
https://reviewboard.mozilla.org/r/184066/#review190194
Attachment #8912754 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Comment 9•7 years ago
|
||
Found one more test failure, sigh.
The sourceRoot-resetting thing is not needed any more; I'm removing it from devtools-source-map as well;
so removing it here.
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 11•7 years ago
|
||
Losing it a little.
devtools/server/tests/unit/test_sourcemaps-17.js relied on the old, incorrect, source resolution algorithm.
Not sure why I didn't notice this locally.
| Comment hidden (mozreview-request) |
|
||
Comment 13•7 years ago
|
||
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fcda941d954
update to source-map 0.6.1; r=bgrins
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•