Closed
Bug 1403982
Opened 7 years ago
Closed 7 years ago
--disable-xcode-checks configure option is ineffective
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: tomprince, Assigned: tomprince)
References
Details
Attachments
(1 file)
The check for xcode (added in Bug 1366564) is run in both configure and js/src's configure. But the option to disable it doesn't get passed down to js/src's configure. So passing the option just changes where the error is reported, rather than actually disabling the check.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8913263 [details]
Bug 1403982: Pass --disable-xcode-checks to js/src's configure;
https://reviewboard.mozilla.org/r/184640/#review189820
Attachment #8913263 -
Flags: review?(gps) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8547b76f8dfe
Pass --disable-xcode-checks to js/src's configure; r=gps
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•