Open Bug 1404496 Opened 7 years ago Updated 2 years ago

Window specific themes should not reset when previewing a theme in customize mode

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

People

(Reporter: fx4waldi, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug theme API.xpi
(deleted), application/x-xpinstall
Details
Attached file bug theme API.xpi (deleted) —
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20170929100122 Steps to reproduce: 1. Install an extension from attachment 2 [review]. Open new private window 3. Open "Customization mode" 4. Hover over a theme eg. "Dark theme" (do not click) 5. Close "Customization mode" 6. Open next new window Actual results: 1. The first window (without the red theme) has a theme that was pointed at the cursor. 2. Third window (and each next) has a red theme Expected results: 1. Theme shouldn't change 2. Theme should be applied only to private windows
Blocks: 1342712
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Theme API for a specific window does not work properly → Window specific themes should not reset when previewing a theme in customize mode
Component: Untriaged → Theme
Can you look into this, :ntim?
Flags: needinfo?(ntim.bugs)
This is on my list after bug 1404855
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(ntim.bugs)
Priority: -- → P3
The solution for this bug would be to pass in the outerWindowID to the preview method, and ultimately passed along to the LightWeightThemeConsumer class. IOW: make the preview functionality scoped to the active window. That the preview feature will be cheaper to render is a nice side-effect.
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Blocks: themingapi-ux
No longer blocks: themingapi-polish
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: