Closed Bug 1404543 Opened 7 years ago Closed 7 years ago

Update copy for Sync only over Wi-Fi

Categories

(Firefox for Android Graveyard :: Firefox Accounts, enhancement)

enhancement
Not set
normal

Tracking

(firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
firefox58 --- verified

People

(Reporter: mheubusch, Assigned: Grisha)

References

Details

Attachments

(1 file)

Please update the copy and toggle for the setting that currently reads "Sync over metered connections" The default behavior for this setting is "Always sync unless otherwise instructed by the user" but we are changing the language and the appearance of the toggle. Now, the label should be "Sync only over Wi-Fi" and the copy below should read "Prevent Firefox from syncing over a cellular or metered network" The toggle button should be in the Off state by default.
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Component: Android Sync → Firefox Accounts
Product: Android Background Services → Firefox for Android
Comment on attachment 8913898 [details] Bug 1404543 - Update copy and default values for 'sync over wi-fi' pref https://reviewboard.mozilla.org/r/185308/#review190696 I didn't look too closely at this but I don't see any obvious error/inversion of a boolean/etc. Ship it! ::: mobile/android/services/src/main/res/xml/fxaccount_status_prefscreen.xml:87 (Diff revision 1) > <EditTextPreference > android:singleLine="true" > android:key="device_name" > android:persistent="false" > android:title="@string/fxaccount_status_device_name" /> > <SwitchPreference nit: kill trailing whitespace, here and in strings.xml.
Attachment #8913898 - Flags: review?(nalexander) → review+
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8abf66f0749 Update copy and default values for 'sync over wi-fi' pref r=nalexander
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You should never hard code Firefox in strings. Either we back this out, or you fix it very quickly without changing the ID again.
Flags: needinfo?(gkruglov)
Depends on: 1405430
Fixed in Bug 1405430.
Flags: needinfo?(gkruglov)
Verified as fixed in build 58.0a1 (10-13); Device: Huawei P9 Lite(Android 6.0). The label is "Sync only over Wi-Fi", Off by default and below "Prevent Firefox from syncing over a cellular or metered network".
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: