Closed Bug 1404782 Opened 7 years ago Closed 7 years ago

Do not mutate display list in the layers-free mode

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

(Whiteboard: [wr-mvp])

Attachments

(2 files)

Currently we remove/insert display items from/to the display list when we create WR commands. It may change the original display list and it sometimes makes the retain display list not working.
There is a unexpected-pass test[1], so I remove the fails-if(webrender) for the testcase. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0402bf55e4ff3d8b567cc470c37fb2f13988a90e&selectedJob=134351327
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp]
Comment on attachment 8914243 [details] Bug 1404782 - Do not mutate display list in layers-free mode. https://reviewboard.mozilla.org/r/185564/#review190758
Attachment #8914243 - Flags: review?(matt.woodrow) → review+
Attachment #8914256 - Flags: review?(matt.woodrow) → review+
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db40593b664c Do not mutate display list in layers-free mode. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/6869bf44878d Update reftest annotation after the fix. r=mattwoodrow
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: