Closed
Bug 1404820
Opened 7 years ago
Closed 4 years ago
[Activity Stream] - Double context menu opened
Categories
(Firefox for Android Graveyard :: Activity Stream, defect, P5)
Tracking
(fennec+, firefox57 affected, firefox58 affected)
RESOLVED
INCOMPLETE
People
(Reporter: bsurd, Unassigned)
References
Details
(Whiteboard: [MobileAS])
Device:
- Nexus 6 (Android 7.1.1);
Steps to reproduce:
1. Open Fennec;
2. Go to the Recommended by Pocket section;
3. Double tap on the 3 dot menu for any of the stories.
Expected result:
One context menu is opened.
Actual result:
Two context menus are opened for that item.
Notes:
The same issue can also be reproduced for any highlights item.
This is a concern because for single use items in the menu (eg. bookmarking), the second one is not updated giving the user the possibility to add the same item twice as a bookmark, thus crashing Fennec. Here is a crash report example: https://goo.gl/TZBXKi
Comment 1•7 years ago
|
||
This is because the click listener gets called twice. The ButterKnife library solves this generically with their DebouncingOnClickListener: https://github.com/JakeWharton/butterknife/blob/7f8ee37a05f8e0ee27e45673a38caeee4a0bb418/butterknife/src/main/java/butterknife/internal/DebouncingOnClickListener.java
Comment 2•7 years ago
|
||
But there is a bug in it for some specific cases: https://github.com/JakeWharton/butterknife/issues/766#issuecomment-296715370
Comment 3•7 years ago
|
||
Hi Joe, Wesly
Please help prioritize this.
jcheng@mozilla.com, wehuang@mozilla.com,
Updated•7 years ago
|
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Updated•7 years ago
|
tracking-fennec: ? → +
Comment 4•7 years ago
|
||
I assume we should leave this to AS team?
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Comment 5•7 years ago
|
||
Wesly, I'm only on AS for critical crashes and this doesn't seem critical to me – am I missing something that would show this is critical?
Otherwise, I think the fennec team would have to handle it if you want it fixed.
Flags: needinfo?(wehuang)
Comment 6•7 years ago
|
||
@Michael: my bad. I was not aware of the AS ownership transitioning, and now have refreshed my head : )
@Bogdan: in my test it's not easily repro and I only made it few times when I double-tap the 3-dot menu very quickly. Is this the same as you see, or you actually met this simply with a normal click speed? Another thing interesting though is what's users' expected action on the 3-dot menu, maybe I'm not a normal user anymore but I never think of tapping it twice :), so maybe it's not a common case user will see?
Flags: needinfo?(wehuang) → needinfo?(bogdan.surd)
Reporter | ||
Comment 7•7 years ago
|
||
Hello,
This is not a great concert, this case could apply to slower devices where the menu takes more time to appear and the user manages to tap the menu twice if he is inpatient or rushing to do something.
It is harder to reproduce this on higher end devices since the device is more responsive and the menu appears almost instantly.
After managing to open the menu twice a crash can be simply reproduced by using the same single use option in both menus (eg. bookmarking, pinning).
Flags: needinfo?(bogdan.surd)
Comment 8•7 years ago
|
||
Thanks Bodgan, got it! I did meet the crash as you said when repro the issue successfully. Set P3 given the steps to repro it.
Priority: -- → P3
Comment 9•6 years ago
|
||
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195
Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
Comment 10•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•