Closed
Bug 1404823
Opened 7 years ago
Closed 7 years ago
Name of app bundle changed to FirefoxFirefoxNightly.app
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 59
People
(Reporter: metasieben, Assigned: Sylvestre)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary
(deleted),
text/x-review-board-request
|
rail
:
review+
|
Details |
As a regression of bug 1378834 the app-bundle is currently called >FirefoxFirefoxNightly.app<.
I'm guessing because the >Firefox< prefix is already specified in mozconfig (--with-macbundlename-prefix=Firefox)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sledru
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8914240 [details]
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary
https://reviewboard.mozilla.org/r/185560/#review190586
This seems like the right thing to do, but it needs a review from release engineering[1]. There is at least the whitelist[2] that might need to get changed as well.
[1] https://wiki.mozilla.org/Modules/All#Build_and_Release_Tools
[2] https://dxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/whitelist#45
Attachment #8914240 -
Flags: review?(spohl.mozilla.bugs)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8914240 [details]
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary
https://reviewboard.mozilla.org/r/185560/#review190704
Attachment #8914240 -
Flags: review?(rail) → review+
Updated•7 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/46cdf85f143c73087ba63e1b642eda20a8b490bf
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r?rail
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75fd371db04b2cbffeb01efea4f5b5b52250b921
Bug 1404823 - Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r=rail
Comment 8•7 years ago
|
||
Backed out for build bustages on ../build/compare-mozconfig/compare-mozconfigs-wrapper.py::TestCompareMozconfigs::test_compare_mozconfigs
Treeheder link with the push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8bb8542b3d23f2b590f9c2b1cb9215219527df&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e42260b0a93f097bb38d93aea41970
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152720370&repo=mozilla-inbound&lineNumber=30264
Flags: needinfo?(sledru)
Comment 9•7 years ago
|
||
Backed out for build bustages on ../build/compare-mozconfig/compare-mozconfigs-wrapper.py::TestCompareMozconfigs::test_compare_mozconfigs
Treeheder link with the push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8bb8542b3d23f2b590f9c2b1cb9215219527df&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e42260b0a93f097bb38d93aea41970
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152720370&repo=mozilla-inbound&lineNumber=30264
Comment 10•7 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bca6b0df7212
Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r=rail
Assignee | ||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/2d0c9b0ed55237451749e0ab720007b9c510b4ca
try to unbreak the oak branch by backporting the fix that landed in bug 1404823
Comment 12•7 years ago
|
||
Backed out changeset bca6b0df7212 (bug 1404823) for failing Browser-chrome on toolkit/xre/test/browser_checkdllblockliststate.js on a CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#?job_id=152893594&repo=mozilla-inbound&lineNumber=6086
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e66190460ee40688bbf87cdac4489dac9d7fcf3
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40eb00c21e7c776d4781c28e88a9b0917b4396ce&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=152893594
Comment 13•7 years ago
|
||
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d461768da724
Now that nightly is called Firefox Nightly, with-macbundlename-prefix is not necessary r=rail
Comment 14•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(sledru)
You need to log in
before you can comment on or make changes to this bug.
Description
•