Closed Bug 1405303 Opened 7 years ago Closed 7 years ago

Sometimes page actions are hidden on browser restore

Categories

(Firefox :: Address Bar, enhancement, P5)

58 Branch
x86
Windows 10
enhancement

Tracking

()

RESOLVED INCOMPLETE
Tracking Status
firefox58 --- affected

People

(Reporter: jkt, Unassigned)

References

Details

I sometimes see the meatballs, pocket, star etc hidden on session restore. On inspecting this I see the following CSS causing this: #urlbar[pageproxystate="invalid"] > #page-action-buttons > .urlbar-page-action This appears to be have been put in place by Bug 1388835. I can't cleanly replicate it however it might be to do with having about pages when restoring tabs? I have "Show your windows and tabs from last time" selected in about:preferences
Blocks: 1388835
Whiteboard: [photon-structure][triage]
What's the state of the page that's open on restore when this happens, and does the content of the url bar match that page's url or does it have other typing in it or something?
Flags: needinfo?(jkt)
Priority: -- → P4
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Priority: P4 → P5
Going to close this as incomplete for now and remove from photon lists, because it's not clear what causes this, if it isn't by design, and it's not really related to photon directly as other things will also be hidden if pageproxystate=invalid . If we have more details / solid STR that indicate we're setting pageproxystate=invalid when we shouldn't be, then we can reopen, but that would be a bug irrespective of the state of the page action buttons. Keeping ni for Jonathan in case he has more info here and wants to reopen and look at this again.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [reserve-photon-structure]
Removing NI, I have seen this again recently I think it's poor network+compiling code that triggers it however again I can't produce a solid STR for this still.
Flags: needinfo?(jkt)
You need to log in before you can comment on or make changes to this bug.