Closed
Bug 1405790
Opened 7 years ago
Closed 7 years ago
Update webrender to 6440dff485271cdfd24a22c920cea31e01e2b164
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Blocks 1 open bug)
Details
(Whiteboard: [wr-mvp] [gfx-noted])
Attachments
(5 files)
(deleted),
text/x-review-board-request
|
jrmuizel
:
review+
Gankra
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jrmuizel
:
review+
Gankra
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jrmuizel
:
review+
Gankra
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jrmuizel
:
review+
Gankra
:
review+
|
Details |
+++ This bug was initially created as a clone of Bug #1405399 +++
I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.
When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".
[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Assignee | ||
Comment 1•7 years ago
|
||
WR @ cb06be0e16658c4849328a0acd1e6fac4e3e989b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4b56bc929d8c53b34e9b062540f9009d0f66e9a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75bfdaf78dba1e69346c758d01592665da1294c0
Good so far
Assignee | ||
Comment 2•7 years ago
|
||
WR @ 8f0e0c6afb2b7552eb31d524bbaf52131c226c4f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cba0f76be45eeff51800dadb672ceef22738d059
Bustage, missing push_nested_display_list. (race between bug 1405916 and https://github.com/servo/webrender/pull/1806)
Depends on: 1405916
Assignee | ||
Comment 3•7 years ago
|
||
WR @ 26cf09ccb1b9bd60c087a26865be88fefa7abe84
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ddcfd4eeeb06784b0ce6932e1313e1dee4543a6
WR @ 1a212916e16f2850f78ab2a9b70e44c49fd8ddde
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a999128a39f1dc587d0c83b259f2832ec6f9dee3
Same bustage as before, because the thing that landed on inbound hasn't merged to m-c yet, because of windows infra problems.
Assignee | ||
Comment 4•7 years ago
|
||
WR @ 1a212916e16f2850f78ab2a9b70e44c49fd8ddde
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff0905ef9bab11fd53cd95ccd28b799d8b8d84e5
Still busted. Some font render mode stuff, which I hope will be fixed by the patch on bug 1406138. And some nesting_index stuff, which seems to indicate we didn't properly remove the nested display list goop.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 5•7 years ago
|
||
WR @ 4052fe4ee9987ea0d96f7492ac87c26ce28ac4ad with local build fixes
https://treeherder.mozilla.org/#/jobs?repo=try&revision=db4781b2003abee8db3da7bd5fcccad59d21d107
Updated•7 years ago
|
Assignee | ||
Comment 6•7 years ago
|
||
WR @ c8d82c3cf212071262516b899f04476e3351e8f5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=01f02a7a0f32e7705f6fea750bd1e859c529725d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=abf6bd5574c876569ab0f310d35cb967a723e326
https://treeherder.mozilla.org/#/jobs?repo=try&revision=660bc68e0807ea90d586710828fc6b4ab7aab1fd
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e52ab02dc05bba6404b7b12a2bfba5ab7e6105a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f09aaf642130a366934067ad155d4d29e3ba8339
https://treeherder.mozilla.org/#/jobs?repo=try&revision=adacbc610e7362cedc9fc8a82f82de9b1f040b63
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a06eda2bdae94751672f3fbb1e6be0ef92af93b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ff6902b2c0defb06ec8d51bd6c91f1eddba11ee
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99e4e978242cccbc22a0f559e74b000d0c853358
https://treeherder.mozilla.org/#/jobs?repo=try&revision=32b40e87ce47a00585592bd47c4a5d13187fa374
All green pretty much
WR @ 16251d8abb39eb79bb6ab4873490821b9b036823
https://treeherder.mozilla.org/#/jobs?repo=try&revision=af2c243b13de01e1f1ea44d1bbd075617df7b371
https://treeherder.mozilla.org/#/jobs?repo=try&revision=855199119db07cbad6da2a9cc39bfa6820af2c6c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4db2a0d3e55e56a914574ddaaf0f076e9d225c77
https://treeherder.mozilla.org/#/jobs?repo=try&revision=81f3ee293571660c91a613f4e3bae8c7428eb032
A bunch of unexpected-passes, one unexpected-fail. From one or more changes in this set, almost certainly servo/webrender#1791
* 16251d8a (HEAD -> master, origin/master, origin/auto, origin/HEAD) Auto merge of #1825 - jrmuizel:abort, r=glennw
|\
| * 6af8c836 Use panic=abort instead of panic=unwind
* 59502ed1 Auto merge of #1791 - nical:corner, r=glennw
|\
| * 7a336bd5 Update the reference images.
| * 159da591 Clamp the modulated border colors to valid values.
| * ab09be18 Use a better approximation for the border corner shader.
* 17033a9c Auto merge of #1823 - Gankro:save2, r=kvark
|\
| * 1bff2395 Make save-restore foolproof
* a40e1ca1 Auto merge of #1830 - jrmuizel:even-more-unsafe, r=Gankro
* 94e88a57 Make the writer even more unsafe.
Comment 7•7 years ago
|
||
The one failure seems like a reasonable fuzz? Maybe a bit biased b/c this WR update lets me start back up on text testing.
Assignee | ||
Comment 8•7 years ago
|
||
Yeah I'll get this update landed tomorrow.
WR @ 16251d8abb39eb79bb6ab4873490821b9b036823 with reftest updates
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d43fef29857e8c4a84f183f7cb1e48e3ceb0fec
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd63990a57bcab0fbc161f4828a9ad73dcc3e3b9
Assignee | ||
Comment 9•7 years ago
|
||
WR @ 6440dff485271cdfd24a22c920cea31e01e2b164
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbd4673f7c7ccd4200200ba57610820d06af5582
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f0e5e16eca91a9d3b1e0fb8593a58288f23ea23
Green
Assignee | ||
Updated•7 years ago
|
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to 6440dff485271cdfd24a22c920cea31e01e2b164
Version: unspecified → 58 Branch
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8916949 [details]
Bug 1405790 - Update webrender to commit 6440dff485271cdfd24a22c920cea31e01e2b164.
https://reviewboard.mozilla.org/r/187984/#review193150
Attachment #8916949 -
Flags: review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8916950 [details]
Bug 1405790 - Fix for ClipId change in WR cset b4fbc86.
https://reviewboard.mozilla.org/r/187986/#review193152
Attachment #8916950 -
Flags: review+
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8916951 [details]
Bug 1405790 - Mark some tests as passing from WR cset 90aa4c28.
https://reviewboard.mozilla.org/r/187988/#review193154
Attachment #8916951 -
Flags: review+
Comment 19•7 years ago
|
||
mozreview-review |
Comment on attachment 8916952 [details]
Bug 1405790 - supply FontInstancePlatformOptions to WebRender.
https://reviewboard.mozilla.org/r/187990/#review193156
Attachment #8916952 -
Flags: review?(jmuizelaar) → review+
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8916953 [details]
Bug 1405790 - Update some reftest annotations for changes in WR PR 1791.
https://reviewboard.mozilla.org/r/187992/#review193158
Attachment #8916953 -
Flags: review+
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8916953 [details]
Bug 1405790 - Update some reftest annotations for changes in WR PR 1791.
https://reviewboard.mozilla.org/r/187992/#review193160
Attachment #8916953 -
Flags: review?(jmuizelaar) → review+
Comment 22•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8388d2ebc0d0
Update webrender to commit 6440dff485271cdfd24a22c920cea31e01e2b164. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/6a308ba5bb93
Fix for ClipId change in WR cset b4fbc86. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/e44d51fdc331
Mark some tests as passing from WR cset 90aa4c28. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/179ba985f5f9
supply FontInstancePlatformOptions to WebRender. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/20fa8f7c5cac
Update some reftest annotations for changes in WR PR 1791. r=Gankro,jrmuizel
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Comment 23•7 years ago
|
||
mozreview-review |
Comment on attachment 8916949 [details]
Bug 1405790 - Update webrender to commit 6440dff485271cdfd24a22c920cea31e01e2b164.
https://reviewboard.mozilla.org/r/187984/#review193256
Attachment #8916949 -
Flags: review?(jmuizelaar) → review+
Comment 24•7 years ago
|
||
mozreview-review |
Comment on attachment 8916951 [details]
Bug 1405790 - Mark some tests as passing from WR cset 90aa4c28.
https://reviewboard.mozilla.org/r/187988/#review193258
Attachment #8916951 -
Flags: review?(jmuizelaar) → review+
Comment 25•7 years ago
|
||
mozreview-review |
Comment on attachment 8916950 [details]
Bug 1405790 - Fix for ClipId change in WR cset b4fbc86.
https://reviewboard.mozilla.org/r/187986/#review193260
Attachment #8916950 -
Flags: review?(jmuizelaar) → review+
Comment 26•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8388d2ebc0d0
https://hg.mozilla.org/mozilla-central/rev/6a308ba5bb93
https://hg.mozilla.org/mozilla-central/rev/e44d51fdc331
https://hg.mozilla.org/mozilla-central/rev/179ba985f5f9
https://hg.mozilla.org/mozilla-central/rev/20fa8f7c5cac
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•