If displayed animation has 'delay' and 'fill' is 'none' or 'forwards', the 'delay' area in summary graph displays max value. But we should display it's value as 0 since the summary graph should display animation progress which includes easing in keyframes.

test code.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9972444a63696345b64241da41a70dcd3de3014c

Comment on attachment 8915580 [details] Bug 1405983 - Part 1: Display delay area in summary graph as 0 if fill is none or forwards. https://reviewboard.mozilla.org/r/186774/#review192702 ::: devtools/client/animationinspector/graph-helper.js:371 (Diff revision 1) > + // Set 0 as default value since if displayed animation has delay, get original > + // style( default value of opacity 1.0) of targetEl. I don't understand this comment. Can you try to rephrase please? Or explain in a bugzilla comment, maybe I'm just missing something.

Comment on attachment 8915581 [details] Bug 1405983 - Part 2: Modify tests for delay. https://reviewboard.mozilla.org/r/186776/#review192728

(In reply to Patrick Brosset <:pbro> from comment #5) > Comment on attachment 8915580 [details] > Bug 1405983 - Part 1: Display delay area in summary graph as 0 if fill is > none or forwards. > > https://reviewboard.mozilla.org/r/186774/#review192702 > > ::: devtools/client/animationinspector/graph-helper.js:371 > (Diff revision 1) > > + // Set 0 as default value since if displayed animation has delay, get original > > + // style( default value of opacity 1.0) of targetEl. > > I don't understand this comment. Can you try to rephrase please? Or explain > in a bugzilla comment, maybe I'm just missing something. I haven't looked at the patch, but just looking at this comment (and based on my discussion with Daisuke-san about this bug) I suspect this should be something like: // Set the underlying opacity to zero so that if we sample the animation's output // during the delay phase and it is not filling backwards, we get zero.

Wao, thank you, Brian!

Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2d9bd9f5561 Part 1: Display delay area in summary graph as 0 if fill is none or forwards. r=pbro https://hg.mozilla.org/integration/autoland/rev/34563d832147 Part 2: Modify tests for delay. r=pbro

https://hg.mozilla.org/mozilla-central/rev/c2d9bd9f5561 https://hg.mozilla.org/mozilla-central/rev/34563d832147