Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023) Assignee
	Comment 1 • 7 years ago
mozreview-request

Comment hidden (mozreview-request)

This just isn't used any more; get rid of it.  We might want to put
Gradle packages in the tree in the future, so keep
mobile/android/gradle/m2repo.

Review commit: https://reviewboard.mozilla.org/r/187356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187356/

	Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023) Assignee
	Comment 2 • 7 years ago
mozreview-request

Comment hidden (mozreview-request)

The goal of this approach is to tell Gradle to not connect (or allow
it to connect) to the network when fetching dependencies.  No Android
automation tasks should fetch from the network, except the toolchain
tasks (which are specially intended to do so).

It's difficult to arrange this without including the `--offline` flag
everywhere.  It _should_ be possible to set offline using an
environment variable -- which would allow us to get rid of these
dotgradle-* files -- but offline isn't an option in
https://docs.gradle.org/4.2.1/userguide/build_environment.html#sec:gradle_configuration_properties
(and certainly not in earlier versions either).  Therefore,
environment variable that points to an init.gradle file in automation.

Before this patch, the files telling Gradle whether to start offline
were fetched from tooltool.  That's just a layer that doesn't need to
be there.

None of this impacts local developers.

Review commit: https://reviewboard.mozilla.org/r/187358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187358/

	Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023) Assignee
	Comment 5 • 7 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8916126 [details]
Bug 1406196 - Pre: Cull unused Gradle plugin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187356/diff/1-2/

	Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023) Assignee
	Comment 6 • 7 years ago
mozreview-request

Comment hidden (mozreview-request)

Comment on attachment 8916127 [details]
Bug 1406196 - Move GRADLE_USER_HOME in tree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187358/diff/1-2/