Closed Bug 1406250 Opened 7 years ago Closed 7 years ago

osx64 repack failing : invalid value 'gnu++11' in '-std=gnu++11'

Categories

(SeaMonkey :: Release Engineering, defect)

SeaMonkey 2.49 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.49

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

Getting this failure in the OSX64 repack, configure step: Reexecuting in the virtualenv Adding configure options from /builds/slave/rel-c-esr-osx64-rpk/build/comm-esr52/.mozconfig --with-google-api-keyfile=/builds/google-api.key --with-l10n-base=../../l10n --enable-application=suite --enable-update-channel=release --enable-rust MOZILLA_OFFICIAL=1 RUSTC=/builds/slave/rel-c-esr-osx64-rpk/build/comm-esr52/rustc/bin/rustc CARGO=/builds/slave/rel-c-esr-osx64-rpk/build/comm-esr52/cargo/bin/cargo MOZ_ADDON_SIGNING=0 MOZ_REQUIRE_SIGNING=0 checking for a shell... /bin/sh checking for host system type... x86_64-apple-darwin11.4.2 checking for target system type... x86_64-apple-darwin11.4.2 checking whether cross compiling... no checking for pkg_config... not found checking for yasm... /usr/local/bin/yasm checking yasm version... 1.3.0 checking for the target C compiler... /usr/bin/clang checking whether the target C compiler can be used... yes checking the target C compiler version... 2.1.0 checking the target C compiler works... yes checking for the target C++ compiler... /usr/bin/clang++ checking whether the target C++ compiler can be used... DEBUG: <truncated - see config.log for full output> DEBUG: | #elif __FreeBSD__ DEBUG: | %KERNEL "FreeBSD" DEBUG: | #elif __linux__ DEBUG: | %KERNEL "Linux" DEBUG: | #elif _WIN32 || __CYGWIN__ DEBUG: | %KERNEL "WINNT" DEBUG: | #elif __NetBSD__ DEBUG: | %KERNEL "NetBSD" DEBUG: | #elif __APPLE__ DEBUG: | %KERNEL "Darwin" DEBUG: | #endif DEBUG: | #if _MSC_VER || __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ DEBUG: | %ENDIANNESS "little" DEBUG: | #elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ DEBUG: | %ENDIANNESS "big" DEBUG: | #endif DEBUG: Executing: `/usr/bin/clang++ -std=gnu++11 -E /var/folders/bm/kc_3cyjj2v15yn2741pj8s6r0000gn/T/conftest.WTbGv_.cpp` DEBUG: The command returned non-zero exit status 1. DEBUG: Its error output was: DEBUG: | error: invalid value 'gnu++11' in '-std=gnu++11' ERROR: Command `/usr/bin/clang++ -std=gnu++11 -E /var/folders/bm/kc_3cyjj2v15yn2741pj8s6r0000gn/T/conftest.WTbGv_.cpp` failed with exit status 1. *** Fix above errors and then restart with "make -f client.mk build" make: *** [configure] Error 1 program finished with exit code 2 elapsedTime=17.422105
I've found that the issue was that we aren't even using the right clang.
Attached patch [mozconfigs] proposed patch (obsolete) (deleted) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8916194 - Flags: review?(frgrahl)
Comment on attachment 8916194 [details] [diff] [review] [mozconfigs] proposed patch Looks good. So the repack needs the compiler. Shouldn't this be . $topsrcdir/build/macosx/universal/mozconfig.common for comm-esr52? r+ with question answered.
Attachment #8916194 - Flags: review?(frgrahl) → review+
(In reply to Frank-Rainer Grahl (:frg) from comment #3) > Comment on attachment 8916194 [details] [diff] [review] > [mozconfigs] proposed patch > > Looks good. So the repack needs the compiler. Shouldn't this be > > . $topsrcdir/build/macosx/universal/mozconfig.common > > for comm-esr52? r+ with question answered. That is correct. Fixing.
Attachment #8916194 - Attachment is obsolete: true
Attachment #8916465 - Flags: review+
Comment on attachment 8916465 [details] [diff] [review] [mozconfigs] fix for proposed patch [Triage Comment] Was pushed to comm-esr52's SEAMONKEY_2_49_ESR_RELBRANCH relbranch. Going to transplant to default.
Attachment #8916465 - Flags: approval-comm-beta+
Pushed to default branch of comm-esr52: https://hg.mozilla.org/releases/comm-esr52/rev/3fa19c7d3367
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: