Closed
Bug 1406310
Opened 7 years ago
Closed 7 years ago
Also ship clang-format in the clang-tidy build job
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Instead of creating a new job, I propose that we use the clang-tidy artifact.
we should probably rename it as a next step like "clang-tooling" or "clang-toolchain".
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sledru
Comment 1•7 years ago
|
||
I propose using already implemented helper for getting the resources: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#2385
And besides this maybe it's a good idea to also keep the same directory for the resources, and like you said renaming it to clang-tooling.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8915863 [details]
Bug 1406310 - Also ship clang-format in the clang-tidy build job
https://reviewboard.mozilla.org/r/187112/#review193054
Don't land this until bug 1405570 is fixed.
Attachment #8915863 -
Flags: review?(mh+mozilla) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1daa8a6f30db
Also ship clang-format in the clang-tidy build job r=glandium
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•