Closed
Bug 1406410
Opened 7 years ago
Closed 7 years ago
Location input field in Full Page Edit Bookmark dialogue doesn't use URI inputtype
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: JanH, Assigned: JanH)
References
Details
Attachments
(1 file)
Jing-wei, can you still remember whether there was a particular reason you've used "textNoSuggestions" here instead of "textUri"?
Flags: needinfo?(topwu.tw)
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8916073 [details]
Bug 1406410 - Use URI input type when editing a bookmark's URL.
https://reviewboard.mozilla.org/r/187312/#review192592
Attachment #8916073 -
Flags: review?(topwu.tw) → review+
|
|
||
Comment 4•7 years ago
|
||
Sorry I have no idea why I use 'textNoSuggestions' instead of 'textUri' here and I cannot find and spec or document related to it.
Revert the input type back to 'textUri' is probably a better choice.
Flags: needinfo?(topwu.tw)
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/c80fdbc040cb
Use URI input type when editing a bookmark's URL. r=jwu
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•