Closed Bug 1406434 Opened 7 years ago Closed 7 years ago

webrtc.org v49 import broke ice restart and rollback counts on about:webrtc

Categories

(Core :: WebRTC: Networking, defect, P2)

Product:
Core
Component:
WebRTC: Networking
Version:
53 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1406434 - fixing ice restart and rollback counts on about:webrtc.
(deleted), text/x-review-board-request
ng
: review+
Details
The v49 import (126348e718d0) pushed on 2016/12/29 overwrote the changes in PeerConnectionImpl.{h|cpp} for Bug 1321628.
Rank: 19
Comment on attachment 8916048 [details] Bug 1406434 - fixing ice restart and rollback counts on about:webrtc. https://reviewboard.mozilla.org/r/187308/#review192342
Attachment #8916048 - Flags: review?(na-g) → review+
Depends on: 1321628, 1250356
Keywords: regression
Pushed by mfroman@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/cb5a6eedfffa fixing ice restart and rollback counts on about:webrtc. r=ng
https://hg.mozilla.org/mozilla-central/rev/cb5a6eedfffa
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Given that we've been shipping with this bug since 53, it seems like this can ride the 58 train? Feel free to set the status for 57 back to affected and nominate it for approval if you feel strongly otherwise.
Blocks: 1250356
status-firefox56: --- → wontfix
status-firefox57: --- → wontfix
status-firefox-esr52: --- → unaffected
No longer depends on: 1250356
Version: 58 Branch → 53 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: