Closed Bug 1406828 Opened 7 years ago Closed 7 years ago

(photon) (RTL) Back/forward buttons aren't Photon style on 4.2 tablet when RTL is enabled

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
Unspecified
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox57 verified, firefox58 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: jwu, Assigned: jwu)

References

Details

(Whiteboard: [FNC][SPT58.2][INT])

Attachments

(2 files)

back/forward buttons on tablet
(deleted), image/png
Details
Bug 1406828 - Update back/forward icons for RTL on tablet.
(deleted), text/x-review-board-request
cnevinchen
: review+
ritu
: approval-mozilla-beta+
Details
Attached image back/forward buttons on tablet (deleted) —
Devices: Nexus 10 emulator (Android 4.2) Build: Nightly Steps to reproduce: 1. On a tablet device, set the browser language to an RTL supported language. Expected result: The back/forward buttons aren't Photon style. Actual result: The back/forward buttons should be Photon style.
Comment on attachment 8916493 [details] Bug 1406828 - Update back/forward icons for RTL on tablet. https://reviewboard.mozilla.org/r/187636/#review192638
Attachment #8916493 - Flags: review?(cnevinchen) → review+
Pushed by topwu.tw@gmail.com: https://hg.mozilla.org/integration/autoland/rev/71d6058e889b Update back/forward icons for RTL on tablet. r=nechen
https://hg.mozilla.org/mozilla-central/rev/71d6058e889b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8916493 [details] Bug 1406828 - Update back/forward icons for RTL on tablet. Approval Request Comment [Feature/Bug causing the regression]: Update back/forward icons for RTL on tablet [User impact if declined]: This is a visual enhancement as part of Photon related UI bug. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: No, we just update several back/forward icons. No code logic or UI layout changed. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: We just change images for back/forward icons on tablet. [String changes made/needed]: No
Attachment #8916493 - Flags: approval-mozilla-beta?
Comment on attachment 8916493 [details] Bug 1406828 - Update back/forward icons for RTL on tablet. Fennec photon, Beta57+
Attachment #8916493 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [FNC][SPT58.2][INT]
Verified as fixed on both latest Nightly and beta (57.0b9). Devices: Lenovo Yoga Tablet 2 (Android 4.4.2) Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
status-firefox58: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: