Closed Bug 1406874 Opened 7 years ago Closed 7 years ago

(photon) Show color indicator for the selected tab strip on tablet

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Unspecified
Android
defect
Not set
normal

Tracking

(firefox57 verified, firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: jwu, Assigned: jwu)

References

Details

(Whiteboard: [FNC][SPT58.2][INT])

Attachments

(2 files)

Attached image tab strip indicator (deleted) —
We would like to show a color indicator on selected tab strip on tablet. 1. Blue (#0060DF) for normal mode, and 2. Purple (#8000D7) for private mode. Check the attachment for the visual spec.
Comment on attachment 8916547 [details] Bug 1406874 - Show a color indicator for the selected tab strip on tablet. https://reviewboard.mozilla.org/r/187690/#review192766
Attachment #8916547 - Flags: review?(cnevinchen) → review+
Pushed by topwu.tw@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a9d5a7f5b04d Show a color indicator for the selected tab strip on tablet. r=nechen
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8916547 [details] Bug 1406874 - Show a color indicator for the selected tab strip on tablet. Approval Request Comment [Feature/Bug causing the regression]: Show color indicator for the selected tab strip on tablet [User impact if declined]: This is a visual enhancement as part of Photon related UI bug. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: Yes, here is the STR: 1. Launch Fennec on tablet, 2. Add a new tab, check the selected tab strip has a color indicator enabled. Also you can check the visual spec in attachment 8916545 [details] [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: We only add a indicator view on tab strip and has tried our best to keep the code logic as simple as possible. [String changes made/needed]: No
Attachment #8916547 - Flags: approval-mozilla-beta?
Comment on attachment 8916547 [details] Bug 1406874 - Show a color indicator for the selected tab strip on tablet. Fennec photon, beta57+
Attachment #8916547 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [FNC][SPT58.2][INT]
Verified as fixed on both latest Nightly and beta (57.0b9). This issue was tested on a Pixel C(Android 7.1.1)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: