Closed
Bug 1407153
Opened 7 years ago
Closed 7 years ago
Highlights overlaps the "Top sites" when more than 42 Top Sites are displayed
Categories
(Firefox :: New Tab Page, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
| firefox59 | --- | fixed |
People
(Reporter: tmpguy, Assigned: Mardak)
References
Details
(Keywords: polish, regression)
User Story
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
screenshot.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.109 Safari/537.36
Build ID: 20171009220104
Steps to reproduce:
I'd "browser.newtabpage.activity-stream.topSitesCount" value to 50, then I'd open a tab.
Actual results:
When I enable "Hightlights" or "Recommended by Pocket" check mark from New Tab Preferences, they'll overlaps through each other.
It was ok on previous version (I mean from 58.0a1 and 6 or 7 updates later).
Expected results:
There should be a padding between items of each one.
Component: Untriaged → Activity Streams: Newtab
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
|
||
Comment 1•7 years ago
|
||
The issue is also reproducible on Windows 10 and Mac 10.12 on the latest Nightly 58.0a1 (Build ID 20171009220104).
Last good revision: 63618add0894f613af2a5b7939a60c2251443ddf
First bad revision: 8095eff05ac94898f4c8bf28340533f5aa7eaf68
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=63618add0894f613af2a5b7939a60c2251443ddf&tochange=8095eff05ac94898f4c8bf28340533f5aa7eaf68
Blocks: 1405539
Status: UNCONFIRMED → NEW
status-firefox57:
--- → unaffected
status-firefox58:
--- → affected
Ever confirmed: true
Keywords: regression
OS: Linux → All
Summary: Highlights overlaps the "Top sites" → Highlights overlaps the "Top sites" when more than 42 Top Sites are displayed
|
Assignee | |
Updated•7 years ago
|
|
||
Comment 2•7 years ago
|
||
This seems kinda polish-y. Let's not block release on it (esp. since it's not a default pref value).
Keywords: polish
|
|
Assignee | |
Comment 3•7 years ago
|
||
Fixed by bug 1407228 https://github.com/mozilla/activity-stream/pull/3808 uplifted via bug 1415812.
https://hg.mozilla.org/mozilla-central/rev/b4d1db669c93
Assignee: nobody → edilee
Blocks: 1415812
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Priority: -- → P3
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
status-firefox-esr52:
--- → unaffected
Target Milestone: --- → Firefox 59
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
User Story: (updated)
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•