Closed
Bug 1407276
Opened 7 years ago
Closed 5 years ago
Avoid full ResetInterception when we skip FetchEvent dispatch due to no fetch handler being registered
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: bkelly, Assigned: edenchuang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
While measuring performance for bug 1391693 I realized that there is a measurable penalty for internal redirects at times. Its particularly noticeable in non-e10s mode.
Our no-fetch optimization currently triggers an interception and then calls ResetInterception() which does an internal redirect to reset the channel. We should consider avoiding the interception altogether in this case.
The one tricky thing to get right, though, is we still want to trigger a possible update check. Making sure that still happened was why we originally entered the interception path in this case.
Updated•7 years ago
|
Priority: -- → P2
Comment 1•5 years ago
|
||
:perry, as we are going e10s soon, and I read "Its particularly noticeable in non-e10s mode.", can we close this then? Or is it something that still bites us?
Flags: needinfo?(perry)
Comment 2•5 years ago
|
||
I believe this is the same as bug 1609936, Yaron can you confirm?
Flags: needinfo?(perry) → needinfo?(ytausky)
Comment 3•5 years ago
|
||
Yes, it's the same thing. I'll close the other one.
Flags: needinfo?(ytausky)
Updated•5 years ago
|
Assignee: nobody → perry
Assignee | ||
Comment 5•5 years ago
|
||
Hello Perry, If you don't mind, I could take this bug.
Assignee | ||
Updated•5 years ago
|
Assignee: perry → echuang
Assignee | ||
Comment 8•5 years ago
|
||
Assignee | ||
Comment 9•5 years ago
|
||
Here is a raptor try result to evaluate the improvement by patch.
Comment 10•5 years ago
|
||
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b092833a6ef
Avoid creating InterceptedHttpChannel if the service worker has no fetch event handler r=dom-workers-and-storage-reviewers,asuth
Comment 11•5 years ago
|
||
Backed out changeset 0b092833a6ef (Bug 1407276) for wpt14 permafailures CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291997140&repo=autoland&lineNumber=3905
Flags: needinfo?(echuang)
Comment 12•5 years ago
|
||
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36a13a8545e4
Backed out changeset 0b092833a6ef for wpt14 permafailures CLOSED TREE
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(echuang)
Comment 13•5 years ago
|
||
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d32be4ed8786
Avoid creating InterceptedHttpChannel if the service worker has no fetch event handler r=dom-workers-and-storage-reviewers,asuth
Comment 14•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Comment 15•5 years ago
|
||
Backed out d32be4ed8786 for causing bug 1609665 to spike.
Backout: https://hg.mozilla.org/mozilla-central/rev/4c982daa151954c59f20a9b9ac805c1768a350c2
Status: RESOLVED → REOPENED
status-firefox76:
fixed → ---
Flags: needinfo?(echuang)
Resolution: FIXED → ---
Target Milestone: mozilla76 → ---
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(echuang)
Comment 16•5 years ago
|
||
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0666d5b6f6a5
Avoid creating InterceptedHttpChannel if the service worker has no fetch event handler r=dom-workers-and-storage-reviewers,asuth
Comment 17•5 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•