Closed Bug 1407276 Opened 7 years ago Closed 5 years ago

Avoid full ResetInterception when we skip FetchEvent dispatch due to no fetch handler being registered

Categories

(Core :: DOM: Service Workers, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: bkelly, Assigned: edenchuang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

While measuring performance for bug 1391693 I realized that there is a measurable penalty for internal redirects at times. Its particularly noticeable in non-e10s mode. Our no-fetch optimization currently triggers an interception and then calls ResetInterception() which does an internal redirect to reset the channel. We should consider avoiding the interception altogether in this case. The one tricky thing to get right, though, is we still want to trigger a possible update check. Making sure that still happened was why we originally entered the interception path in this case.
Priority: -- → P2

:perry, as we are going e10s soon, and I read "Its particularly noticeable in non-e10s mode.", can we close this then? Or is it something that still bites us?

Flags: needinfo?(perry)

I believe this is the same as bug 1609936, Yaron can you confirm?

Flags: needinfo?(perry) → needinfo?(ytausky)

Yes, it's the same thing. I'll close the other one.

Flags: needinfo?(ytausky)
Blocks: 1587759
Assignee: nobody → perry

Hello Perry, If you don't mind, I could take this bug.

See comment 5.

Flags: needinfo?(perry)
Assignee: perry → echuang

I just asked Eden to go ahead with this.

Flags: needinfo?(perry)
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b092833a6ef Avoid creating InterceptedHttpChannel if the service worker has no fetch event handler r=dom-workers-and-storage-reviewers,asuth
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36a13a8545e4 Backed out changeset 0b092833a6ef for wpt14 permafailures CLOSED TREE
Flags: needinfo?(echuang)
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d32be4ed8786 Avoid creating InterceptedHttpChannel if the service worker has no fetch event handler r=dom-workers-and-storage-reviewers,asuth
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Status: RESOLVED → REOPENED
Flags: needinfo?(echuang)
Resolution: FIXED → ---
Target Milestone: mozilla76 → ---
Regressions: 1621746
Flags: needinfo?(echuang)
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0666d5b6f6a5 Avoid creating InterceptedHttpChannel if the service worker has no fetch event handler r=dom-workers-and-storage-reviewers,asuth
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: