Closed
Bug 1407427
Opened 7 years ago
Closed 6 years ago
Port libs rules in browser/locales/Makefile.in for searchplugins
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1437942
People
(Reporter: mshal, Unassigned)
Details
Supporting these files may depend on a solution for l10n.
Comment 1•7 years ago
|
||
Please CC me on all bugs related to changes to the l10n build system.
Reporter | ||
Comment 2•7 years ago
|
||
Ahh, sorry about that.
Also I mixed this file up with toolkit/locales/Makefile.in. I'll file a separate bug for that.
Summary: Port libs rules in browser/locales/Makefile.in for update.locale and crashreporter.ini to moz.build → Port libs rules in browser/locales/Makefile.in for searchplugins, crashreporter-override.ini and updater.ini
Comment 3•7 years ago
|
||
The crashreporter-override.ini and updater.ini rules are handled in the patches on bug 1409721. We looked into this at our work week last week and the searchplugins stuff, while complicated, doesn't have to block tup because there's already a workaround for the fastermake backend that tup can use.
We should still figure out how to move the Makefile.in rules for searchplugins to moz.build, but I think that's going to depend on fixing repacks first.
No longer blocks: buildtup
Depends on: l10nrepacks
Summary: Port libs rules in browser/locales/Makefile.in for searchplugins, crashreporter-override.ini and updater.ini → Port libs rules in browser/locales/Makefile.in for searchplugins
Updated•7 years ago
|
Product: Core → Firefox Build System
Comment 4•6 years ago
|
||
This ticket is racing against https://bugzilla.mozilla.org/show_bug.cgi?id=1437942 and friends; I'm commenting here in case we can make progress on the expression of things currently localized before changing the product (and build) requirements of searchplugins.
Right now we have two distinct crufty implementations of locale-aware searchplugins generation, one in browser/locales/Makefile.in and one in mobile/locales/Makefile.in. For hysterical raisins they operate pretty differently; I'll mostly discuss the Desktop implementation here.
We're doing a bunch of locale-aware work in b/l/Makefile.in to list search plugins for a locale and then package the correct ones in the omnijar. That gets incorporated into the jar.mn at
https://searchfox.org/mozilla-central/rev/dc6d85680539cb7e5fe2843d38a30a0581bfefe1/browser/locales/jar.mn#63-69
With LOCALIZED_GENERATED_FILES we should be able to migrate the list.json part into moz.build. The searchplugins themselves are a little more tricky, but we should be able to figure out where to write the outputs. Like Bug 1464128, there's a question of whether we keep the entries in the jar.mn file (including a wildcard?) or just write into the correct locale-aware locations inside FINAL_TARGET.
Comment 5•6 years ago
|
||
Well, you wrote patches over there, so let's just call it a day here.
No longer blocks: nomakefiles
Status: NEW → RESOLVED
Closed: 6 years ago
No longer depends on: l10nrepacks, 1107635
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•