Emilio Cobos Álvarez (:emilio) Assignee
	Description • 7 years ago

It's pretty wrong for <html:content> elements.

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 2 • 7 years ago

Err, maybe this is wrong.... Let me just read more.

	Ben Tian (inactive)
	Comment 3 • 7 years ago

<html:content> elements are deprecated in shadow DOM v1. We should rewrite with HTMLSlotElement [1]. See [2] for v0 and v1 comparison.

[1] https://html.spec.whatwg.org/multipage/scripting.html#htmlslotelement
[2] https://hayato.io/2016/shadowdomv1/#insertion-points-v0-vs-slots-v1

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 4 • 7 years ago

Let's resolve this as incomplete.

I still think that that function is wrong, conceptually, in the sense that it has both a super-confusing naming, and that actually returns true when the <content> element doesn't distribute its children (and renders the fallback content).

This works because of the hacky way we deal with fallback content in UpdateFallbackDistribution (adding an explicit insertion point to the fallback content pointing to the light tree parent), but that looks like a hack to me, or at least it looks like it shouldn't be needed.

Anyway, given we're ditching <content>, I don't think it's worth to refactor it or what not.

	Emilio Cobos Álvarez (:emilio) Assignee
	Comment 5 • 7 years ago

(In reply to Emilio Cobos Álvarez [:emilio] from comment #4)
> Let's resolve this as incomplete.

Or as invalid, given I don't know how to use a dropdown menu...