Stefan Plewako [:stef] Reporter
	Description • 7 years ago

https://hg.mozilla.org/mozilla-central/diff/b9e11056a978/browser/locales/en-US/chrome/browser/browser.dtd

Some localizations are sensitive to what is being translated and using such misleading identifiers (it is checkbox not button label) results in bad l10n.

Please change id to sth like customizeMode.autoHideDownloadsButtonCheckbox.label

	:Gijs (he/him)
	Comment 1 • 7 years ago

(In reply to Stefan Plewako [:stef] from comment #0)
> https://hg.mozilla.org/mozilla-central/diff/b9e11056a978/browser/locales/en-
> US/chrome/browser/browser.dtd
> 
> Some localizations are sensitive to what is being translated and using such
> misleading identifiers (it is checkbox not button label) results in bad l10n.

It's the "downloadsbutton" that is being autohidden, so I think the label makes sense...

I mean, I'll take a patch, but clearly it's too late now. Maybe a localization comment would be better?

	Stefan Plewako [:stef] Reporter
	Comment 2 • 7 years ago

(In reply to :Gijs (no reviews, PTO end of today - Nov) from comment #1)
> (In reply to Stefan Plewako [:stef] from comment #0)
> > https://hg.mozilla.org/mozilla-central/diff/b9e11056a978/browser/locales/en-
> > US/chrome/browser/browser.dtd
> > 
> > Some localizations are sensitive to what is being translated and using such
> > misleading identifiers (it is checkbox not button label) results in bad l10n.
> 
> It's the "downloadsbutton" that is being autohidden, so I think the label
> makes sense...

I mean customizeMode.autoHideDownloadsButton.label is not "Auto hide downloads" button label, it is a checkbox label.
In Polish (and some other locales) we translate differently whenever text is title, button, option, list, tooltip or content.

> I mean, I'll take a patch, but clearly it's too late now. Maybe a
> localization comment would be better?

I doubt that l10n note would be sufficient but that is really not my call.
I could make a patch when if it will be clear what change we want to see.