Closed
Bug 1407618
Opened 7 years ago
Closed 7 years ago
Crash in @0x0 | mozilla::wr::RenderDXGITextureHostOGL::EnsureLockable
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox56 | --- | unaffected |
| firefox57 | --- | unaffected |
| firefox58 | --- | verified |
People
(Reporter: marcia, Assigned: jerry)
References
(Blocks 1 open bug)
Details
(Keywords: crash, regression, Whiteboard: [wr-mvp])
Crash Data
Attachments
(1 file)
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-7b8a423f-2edb-4da6-8437-841690171011.
=============================================================
Seen while looking at nightly data. Crashes started on 20171005100211: http://bit.ly/2g0GVfv
29 crashes/5 installs so far.
|
||
Updated•7 years ago
|
Whiteboard: [wr-mvp] [triage]
|
|
||
Updated•7 years ago
|
|
||
Comment 1•7 years ago
|
||
There are 69 in nightly 58 vs 8 crashes in nightly 57.
:nical, could you investigate please ?
Flags: needinfo?(nical.bugzilla)
|
||
Comment 2•7 years ago
|
||
I suspect it is actually the same issue as Bug 1407748.
|
||
Comment 3•7 years ago
|
||
Jerry, you have looked more closely into DXGI textures with webrender, can you have a look?
Flags: needinfo?(nical.bugzilla) → needinfo?(hshih)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → hshih
Status: NEW → ASSIGNED
Flags: needinfo?(hshih)
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Michael Leu[:Lenzak](UTC+8) from comment #2)
> I suspect it is actually the same issue as Bug 1407748.
I also suspect it's the same problem as Bug 1407748. Let's see if there is no more crash after 10/14.
|
|
||
Updated•7 years ago
|
Priority: P2 → P1
|
Reporter | |
Comment 5•7 years ago
|
||
I see a few crashes using 20171015100127.
|
|
Assignee | |
Comment 6•7 years ago
|
||
https://crash-stats.mozilla.com/signature/?signature=%400x0%20%7C%20mozilla%3A%3Awr%3A%3ARenderDXGITextureHostOGL%3A%3AEnsureLockable&date=%3E%3D2017-10-03T10%3A11%3A49.000Z&date=%3C2017-10-17T10%3A11%3A49.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports
This patch try to add more gl texture creation checking in RenderDXGITexture.
1. dxgi shared texture handle.
2. ANGLE_d3d_share_handle_client_buffer ext.
Attachment #8919226 -
Flags: review?(jgilbert)
|
||
Comment 7•7 years ago
|
||
FYI, Bug 1404232 also has a fix attachment 8919215 [details] [diff] [review] that is related to EnsureLockable.
|
|
Assignee | |
Comment 8•7 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> FYI, Bug 1404232 also has a fix attachment 8919215 [details] [diff] [review]
> that is related to EnsureLockable.
Thanks. It will have a problem if we pass a different context from the previous gl context.
|
||
Updated•7 years ago
|
Attachment #8919226 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 9•7 years ago
|
||
|
|
Assignee | |
Comment 10•7 years ago
|
||
Please land the attachment 8919226 [details] [diff] [review] to m-c.
Keywords: checkin-needed
|
||
Comment 11•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af4f28dc9d0
add more gl texture creation checking for RenderDXGITexture. r=jgilbert
Keywords: checkin-needed
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
|
||
Updated•7 years ago
|
Blocks: wr-stability
You need to log in
before you can comment on or make changes to this bug.
Description
•