Closed
Bug 1407624
Opened 7 years ago
Closed 7 years ago
nsEscape.cpp doesn't build in non-unified mode
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(1 file)
nsEscape.cpp doesn't build in non-unified mode, as it uses mozilla::fallible, mozilla::CheckedInt and mozilla::ASCIIMask::IsMasked without prefixing them with the mozilla namespace. I suspect this file is usually included in unified_cpp file which includes a "using namespace mozilla" directive.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8917363 [details]
Bug 1407624 - Make nsEscape.cpp build in non-unified mode.
https://reviewboard.mozilla.org/r/188372/#review193612
Attachment #8917363 -
Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44335b8d480b
Make nsEscape.cpp build in non-unified mode. r=froydnj
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•