Closed
Bug 1407743
Opened 7 years ago
Closed 7 years ago
Show FxA "display name" on top level Settings menu item
Categories
(Firefox for Android Graveyard :: Firefox Accounts, enhancement)
Firefox for Android Graveyard
Firefox Accounts
Tracking
(firefox58 verified)
VERIFIED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | verified |
People
(Reporter: Grisha, Assigned: eoger)
References
Details
(Whiteboard: [FxA])
Attachments
(1 file)
Currently it's just email. Once we fix Bug 1398282 (fixing the height) we'll have more room for the display name.
Updated•7 years ago
|
Whiteboard: [FxA]
Assignee | ||
Comment 1•7 years ago
|
||
I have a patch that would fix bug 1398282 and this one.
What do you think Ryan?
https://imgur.com/i9xHIhq
Flags: needinfo?(rfeeley)
Assignee | ||
Comment 2•7 years ago
|
||
Album with other states: https://imgur.com/a/Mdk9Q
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8920279 [details]
Bug 1407743 - Show display name or "Firefox Accounts" in sync preference button.
https://reviewboard.mozilla.org/r/191300/#review196492
Looks good, sand the string concerns.
::: mobile/android/base/locales/en-US/android_strings.dtd:360
(Diff revision 1)
> <!ENTITY pref_voice_input_summary2 "Allow voice dictation in the URL bar">
> <!ENTITY pref_qrcode_enabled "QR code reader">
> <!ENTITY pref_qrcode_enabled_summary2 "Allow QR scanner in the URL bar">
>
> <!ENTITY pref_use_master_password "Use master password">
> +<!ENTITY pref_sync_default_title "Firefox Account">
I think this should use &brandShortName;, instead of hardcoding "Firefox".
e.g. it would be "Nightly Account" for nightly builds, "Firefox Beta Account", etc.
Or is "Firefox Account" a specific product name? But then, the account could be self-hosted...
Desktop displays "Firefox Account" on my nightly builds, even though elsewhere term "Nightly" is used instead of "Firefox".
Attachment #8920279 -
Flags: review?(gkruglov) → review+
Reporter | ||
Comment 6•7 years ago
|
||
s/sand/sans
Assignee | ||
Comment 7•7 years ago
|
||
Discussed this in a meeting, Firefox Account is OK everywhere. See http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/preferences.dtd#34
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6d36649e0d1
Show display name or "Firefox Accounts" in sync preference button. r=Grisha
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment 11•7 years ago
|
||
Verified as fixed on latest Nightly build.
Device: Huawei MediaPad M2 (Android 5.1.1)
Screenshot: https://i.imgur.com/1AfYQen.png
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•