Closed Bug 1407743 Opened 7 years ago Closed 7 years ago

Show FxA "display name" on top level Settings menu item

Categories

(Firefox for Android Graveyard :: Firefox Accounts, enhancement)

enhancement
Not set
normal

Tracking

(firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
firefox58 --- verified

People

(Reporter: Grisha, Assigned: eoger)

References

Details

(Whiteboard: [FxA])

Attachments

(1 file)

Currently it's just email. Once we fix Bug 1398282 (fixing the height) we'll have more room for the display name.
Whiteboard: [FxA]
I have a patch that would fix bug 1398282 and this one. What do you think Ryan? https://imgur.com/i9xHIhq
Flags: needinfo?(rfeeley)
Album with other states: https://imgur.com/a/Mdk9Q
Got a thumbs up from rfeeley!
Flags: needinfo?(rfeeley)
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Comment on attachment 8920279 [details] Bug 1407743 - Show display name or "Firefox Accounts" in sync preference button. https://reviewboard.mozilla.org/r/191300/#review196492 Looks good, sand the string concerns. ::: mobile/android/base/locales/en-US/android_strings.dtd:360 (Diff revision 1) > <!ENTITY pref_voice_input_summary2 "Allow voice dictation in the URL bar"> > <!ENTITY pref_qrcode_enabled "QR code reader"> > <!ENTITY pref_qrcode_enabled_summary2 "Allow QR scanner in the URL bar"> > > <!ENTITY pref_use_master_password "Use master password"> > +<!ENTITY pref_sync_default_title "Firefox Account"> I think this should use &brandShortName;, instead of hardcoding "Firefox". e.g. it would be "Nightly Account" for nightly builds, "Firefox Beta Account", etc. Or is "Firefox Account" a specific product name? But then, the account could be self-hosted... Desktop displays "Firefox Account" on my nightly builds, even though elsewhere term "Nightly" is used instead of "Firefox".
Attachment #8920279 - Flags: review?(gkruglov) → review+
s/sand/sans
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6d36649e0d1 Show display name or "Firefox Accounts" in sync preference button. r=Grisha
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified as fixed on latest Nightly build. Device: Huawei MediaPad M2 (Android 5.1.1) Screenshot: https://i.imgur.com/1AfYQen.png
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: