Closed
Bug 1408368
Opened 7 years ago
Closed 7 years ago
[dt-onboarding] Move aboutdevtools.dtd out of locales folder until ready for localization
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
aboutdevtools.dtd is missing comments and might also change significantly while we work on follow ups to Bug 1361080. Move this file out of devtools/shim/locales/en-US so that localization tools won't pick it up.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea7fbbf1dc0aec98aae0427a42164a02d16f7d92
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8918258 [details] Bug 1408368 - move aboutdevtools.dtd out of localized folder; https://reviewboard.mozilla.org/r/189106/#review194428 Looks good to me ::: devtools/shim/jar.mn:13 (Diff revision 1) > content/aboutdevtools/aboutdevtools.css (aboutdevtools/aboutdevtools.css) > content/aboutdevtools/aboutdevtools.js (aboutdevtools/aboutdevtools.js) > > content/aboutdevtools/images/otter.png (aboutdevtools/images/otter.png) > > + # Temporary localisation file, move back to devtools/shim/locales/en-US when ready for localization Do we have a bug for that ? It would be nice to refer to it here if we do.
Attachment #8918258 -
Flags: review?(nchevobbe) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
Thanks for the review Nicolas.
> Do we have a bug for that ? It would be nice to refer to it here if we do.
Good point I'll log a follow up and update the comment.
Pike: the goal of this change is to avoid aboutdevtools.dtd being picked up by l10n tools (see summary). Can you confirm moving it to a non-locales folder will do the trick?
Thanks!
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8918258 [details] Bug 1408368 - move aboutdevtools.dtd out of localized folder; https://reviewboard.mozilla.org/r/189106/#review194430 Yeah, this should work.
Attachment #8918258 -
Flags: review?(l10n) → review+
Comment hidden (mozreview-request) |
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6a234f1453e move aboutdevtools.dtd out of localized folder;r=nchevobbe,Pike
![]() |
||
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c6a234f1453e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•