Julian Descottes [:jdescottes] Assignee
	Description • 7 years ago

aboutdevtools.dtd is missing comments and might also change significantly while we work on follow ups to Bug 1361080.

Move this file out of devtools/shim/locales/en-US so that localization tools won't pick it up.

	Julian Descottes [:jdescottes] Assignee
	Comment 2 • 7 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea7fbbf1dc0aec98aae0427a42164a02d16f7d92

	Nicolas Chevobbe [:nchevobbe]
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

https://reviewboard.mozilla.org/r/189106/#review194428

Looks good to me

::: devtools/shim/jar.mn:13
(Diff revision 1)
>      content/aboutdevtools/aboutdevtools.css (aboutdevtools/aboutdevtools.css)
>      content/aboutdevtools/aboutdevtools.js (aboutdevtools/aboutdevtools.js)
>  
>      content/aboutdevtools/images/otter.png (aboutdevtools/images/otter.png)
>  
> +    # Temporary localisation file, move back to devtools/shim/locales/en-US when ready for localization

Do we have a bug for that ? It would be nice to refer to it here if we do.

	Julian Descottes [:jdescottes] Assignee
	Comment 5 • 7 years ago

Thanks for the review Nicolas. 
> Do we have a bug for that ? It would be nice to refer to it here if we do.
Good point I'll log a follow up and update the comment.

Pike: the goal of this change is to avoid aboutdevtools.dtd being picked up by l10n tools (see summary). Can you confirm moving it to a non-locales folder will do the trick? 

Thanks!

	Axel Hecht [:Pike]
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

https://reviewboard.mozilla.org/r/189106/#review194430

Yeah, this should work.

	Pulsebot
	Comment 8 • 7 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6a234f1453e
move aboutdevtools.dtd out of localized folder;r=nchevobbe,Pike

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 9 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c6a234f1453e