Closed Bug 1408455 Opened 7 years ago Closed 7 years ago

Add tooltool manifests for vs2017 builds

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Bug 1408455 - Add tooltool manifests for vs2017.
(deleted), text/x-review-board-request
mshal
: review+
Details
Per bug 1318193, add duplicate tooltool manifests providing Visual Studio 2017 for test builds.
Blocks: 1318193
Attachment #8918372 - Flags: review?(mshal)
Comment on attachment 8918372 [details] Bug 1408455 - Add tooltool manifests for vs2017. https://reviewboard.mozilla.org/r/189188/#review194532 LGTM.
Attachment #8918372 - Flags: review?(mshal) → review+
Please don't. We have support for private toolchains now (bug 1405408). We should use that.
We've been discussing this in other bugs, but unfortunately it's not straightforward to make it work in a toolchain task yet. The VS installer requires admin privileges, which we can't get in the standard TC Windows workers.
See bug 1408458 for replacing this method is private toolchains. That work is too involved to block testing vs2017, which we want for pgo improvements, among other things.
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17acac7a30c2 Add tooltool manifests for vs2017. r=mshal
https://hg.mozilla.org/mozilla-central/rev/17acac7a30c2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: