Closed Bug 1408643 Opened 7 years ago Closed 7 years ago

Message about missing Proguard JAR tells you wrong command to fix the issue

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set
normal

Tracking

(firefox58 wontfix, firefox59 wontfix, firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: JanH, Assigned: jryans)

References

Details

Attachments

(1 file)

The message says > ERROR: proguard.jar 5.3.3 or higher is required (looked for /home/jan/.mozbuild/proguard/lib/proguard.jar). Run |mach artifact install --from-build proguard-jar| or add `export PROGUARD_JAR=/path/to/proguard.jar` to your mozconfig. but then attempting to actually run |mach artifact install --from-build proguard-jar| errors out with > It looks like you passed an unrecognized argument into mach. > > The artifact command does not accept the arguments: --from-build I suppose this needs updating to reference |./mach artifact toolchain -v --from-build proguard-jar| instead?
This message just needs to be updated at http://searchfox.org/mozilla-central/source/build/moz.configure/java.configure#98. The real issue is that |mach artifact toolchain| doesn't install into ~/.mozbuild, since automation wants things in $topsrcdir. So one needs to do |cd ~/.mozbuild && /PATH/TO/mach artifact toolchain|, which sucks. I'd rather add a --cwd flag to |mach artifact toolchain| to avoid needing to figure out the /PATH/TO for the help message.
Just stepped into this. It's still `run |mach artifact install --from-build proguard-jar|` now.
I'll try to clean this up a bit.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8947828 [details] Bug 1408643 - Fix up Proguard install command from configure. https://reviewboard.mozilla.org/r/217516/#review223358 Thank you, sir!
Attachment #8947828 - Flags: review?(nalexander) → review+
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3b7ef7afd156 Fix up Proguard install command from configure. r=nalexander
Flags: needinfo?(jryans)
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bcebc8274aea Fix up Proguard install command from configure. r=nalexander
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: