Closed
Bug 1408643
Opened 7 years ago
Closed 7 years ago
Message about missing Proguard JAR tells you wrong command to fix the issue
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(firefox58 wontfix, firefox59 wontfix, firefox60 fixed)
RESOLVED
FIXED
mozilla60
People
(Reporter: JanH, Assigned: jryans)
References
Details
Attachments
(1 file)
The message says
> ERROR: proguard.jar 5.3.3 or higher is required (looked for /home/jan/.mozbuild/proguard/lib/proguard.jar). Run |mach artifact install --from-build proguard-jar| or add `export PROGUARD_JAR=/path/to/proguard.jar` to your mozconfig.
but then attempting to actually run |mach artifact install --from-build proguard-jar| errors out with
> It looks like you passed an unrecognized argument into mach.
>
> The artifact command does not accept the arguments: --from-build
I suppose this needs updating to reference |./mach artifact toolchain -v --from-build proguard-jar| instead?
Comment 2•7 years ago
|
||
This message just needs to be updated at http://searchfox.org/mozilla-central/source/build/moz.configure/java.configure#98. The real issue is that |mach artifact toolchain| doesn't install into ~/.mozbuild, since automation wants things in $topsrcdir. So one needs to do |cd ~/.mozbuild && /PATH/TO/mach artifact toolchain|, which sucks. I'd rather add a --cwd flag to |mach artifact toolchain| to avoid needing to figure out the /PATH/TO for the help message.
Comment 4•7 years ago
|
||
Just stepped into this. It's still `run |mach artifact install --from-build proguard-jar|` now.
Assignee | ||
Comment 5•7 years ago
|
||
I'll try to clean this up a bit.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8947828 [details]
Bug 1408643 - Fix up Proguard install command from configure.
https://reviewboard.mozilla.org/r/217516/#review223358
Thank you, sir!
Attachment #8947828 -
Flags: review?(nalexander) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3b7ef7afd156
Fix up Proguard install command from configure. r=nalexander
Comment 9•7 years ago
|
||
Backed out for failing flake8 at /builds/worker/checkouts/gecko/build/moz.configure/java.configure:98:100
push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3b7ef7afd156458e6cb2506840c575c1fa42a8ef
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=160153150&repo=autoland&lineNumber=245
Backout: https://hg.mozilla.org/integration/autoland/rev/1eacd71939cbf4316d6cb25ccff41d1be12cfd8c
Flags: needinfo?(jryans)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jryans)
Comment 11•7 years ago
|
||
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bcebc8274aea
Fix up Proguard install command from configure. r=nalexander
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•7 years ago
|
status-firefox59:
--- → wontfix
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 60 → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•