Closed
Bug 140884
Opened 23 years ago
Closed 22 years ago
Rewrapped quoted messages gets space-stuffed
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
WORKSFORME
mozilla1.2alpha
People
(Reporter: kousik, Assigned: bugzilla)
References
Details
Someone sent me a message with a long line. When I replied to it,
mozilla quoted it and sent it unwrapped. The mail went thru' like:
--- 8< ---
Someone wrote:
> I have sent you a really long line of text in this message and expect a reply
Your line is really long :-D
--- 8< ---
(1) mozilla sent out lines longer than 80 characters, not good (rfc 2646, 4.1)
(2) If I choose to "rewrap", the quoted part doesn't stay quoted. They have
their first character as '>' but the lines are assumed normal user typed
line and get space stuffed in the beginning:
--- 8< ---
Someone wrote:
> I have sent you a really long line of text
> in this message and expect a reply
Your line was really long :-D
--- 8< ---
The mailnews client in the receiving end doesn't treat those lines as 'quoted'.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020311
Comment 1•23 years ago
|
||
This happens with f=f. There is a bug about it, I just cannot find it:-(
Related: bug 114954, bug 134439
Not OS-dependend.
pi
OS: Linux → All
Hardware: PC → All
Whiteboard: DUPEME
Comment 2•23 years ago
|
||
Anyways, the bug has been seen by others (newsgroup reports) -> NEW
Akkana should know which one this is -> CC
pi
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•23 years ago
|
||
Akkana, any comment?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2alpha
Comment 4•23 years ago
|
||
I don't know, but Daniel is the expert ...
Comment 5•23 years ago
|
||
Part 1 is because of the bug fix from a couple of weeks ago, Akkana, wasn't that
yours? The bug where we disable wrapping of quoted lines.
Part 2 is a more obvious bug. It shouldn't do that, unless, ah, the rewrapped
quoted text is inserted as pure text, and then the quotes aren't recognized. It
should be inserted as a <blockquote type="cite">. That's my theory anyway.
Comment 6•23 years ago
|
||
> Part 1 is because of the bug fix from a couple of weeks ago.
The change I made a few weeks ago was on a pref, and off by default. The
default behavior should not have changed. The only change that doesn't follow
the pref was in this:
1512,1514c1520,1521
< || (!mQuotesPreformatted && mSpanLevel > 0
< && aString.First() == PRUnichar('>'))) {
---
> || ((((!mQuotesPreformatted && mSpanLevel > 0) || mDontWrapAnyQuotes))
> && mEmptyLines >= 0 && aString.First() == PRUnichar('>'))) {
in other words, we don't go into the "no intelligent wrapping" code used for
quotes if mEmptyLines < 0. Is that wrong? Or am I missing somewhere else where
the default behavior changed?
Comment 7•22 years ago
|
||
Part 1 is not a bug, it's a feature. Bug 32100 deals with this.
The summary only talks about 2 anyways. This is the bug here.
pi
Comment 8•22 years ago
|
||
Is there a chance to get this here and the related bug 114954 fixed? The target
milestone is already in the past. And it is pretty annoying.
pi
Comment 9•22 years ago
|
||
Boris says #2 is the remaining issue here, but #2 sounds like it was a dup of
bug 161143 (Rewrap resets quote status, recently fixed). Are there other issues
remaining here?
Comment 10•22 years ago
|
||
I guess I should not try to answer questions shortly before midnight ... The
only question is if this fix you applied recently solves the problem of
rewrapped quotes being space-stuffed. In theory it should, in practice, I don't
know, it could happen only with f=f. Would have been a side effect of bug 114954.
pi
Comment 11•22 years ago
|
||
I tested the f=f part. It works now. Marking as such.
Akkana, maybe you know which bug deals with the question of rewrapping format
flawed messages when quoting.
pi
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•