Closed Bug 1408951 Opened 7 years ago Closed 7 years ago

Non-unified build failure in xpcom/base/ErrorNames.cpp

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

Bug 1408951 - Fix non-unified build in ErrorNames.cpp.
(deleted), text/x-review-board-request
froydnj
: review+
Details
xpcom/base/ErrorNames.cpp fails to build in non-unified mode, as Gecko_GetErrorName() uses mozilla::GetErrorName() without the mozilla namespace being use'd locally.
Comment on attachment 8918806 [details] Bug 1408951 - Fix non-unified build in ErrorNames.cpp. https://reviewboard.mozilla.org/r/189654/#review194830
Attachment #8918806 - Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5d5e0d4ef33 Fix non-unified build in ErrorNames.cpp. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/d5d5e0d4ef33
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: