Closed
Bug 1409026
Opened 7 years ago
Closed 7 years ago
Missing break statement from element.find_
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-review-board-request
|
Details |
element.find_ is missing a brbeak state in the default clause.
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8918874 [details]
Bug 1409026 - Add missing break statement to find_.
https://reviewboard.mozilla.org/r/189742/#review194906
As already mentioned on the other bug, I don't see why it's needed. The linter doesn't show this as failure, and default always comes last. So this is basically a no-op.
Attachment #8918874 -
Flags: review?(hskupin)
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 8918874 [details]
> Bug 1409026 - Add missing break statement to find_.
>
> https://reviewboard.mozilla.org/r/189742/#review194906
>
> As already mentioned on the other bug, I don't see why it's needed. The
> linter doesn't show this as failure, and default always comes last. So this
> is basically a no-op.
A default case doesn’t always need to come last, but OK. I will drop this.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•