Closed Bug 1409060 Opened 7 years ago Closed 7 years ago

MediaDecoder.h includes necko-config.h unnecessarily

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

Bug 1409060 - Don't include necko-config.h in MediaDecoder.h.
(deleted), text/x-review-board-request
jwwang
: review+
Details
MediaDecoder.h is including necko-config.h, but I can't see any reason why it needs to. necko-config.h just #undefs NECKO_WIFI and NECKO_COOKIES, and we don't depend on those, so I don't see why we need this.
Comment on attachment 8918914 [details] Bug 1409060 - Don't include necko-config.h in MediaDecoder.h. https://reviewboard.mozilla.org/r/189812/#review195206
Attachment #8918914 - Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88383205b1d4 Don't include necko-config.h in MediaDecoder.h. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/88383205b1d4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: