Closed
Bug 1409178
Opened 7 years ago
Closed 7 years ago
Make DecoderTraits not include ChannelMediaDecoder
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(3 files)
DecoderTraits includes ChannelMediaDecoder. This makes it hard to import DecoderTraits into Servo, as we don't want to import ChannelMediaDecoder and its dependencies. So I need to make DecoderTraits not import ChannelMediaDecoder.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919042 [details]
Bug 1409178 - Remove MediaDecoder::InitStatics() since it's a no-op.
https://reviewboard.mozilla.org/r/189956/#review195198
Attachment #8919042 -
Flags: review?(jwwang) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919043 [details]
Bug 1409178 - Merge InstantiateDecoder and DecoderTraits::CreateDecoder.
https://reviewboard.mozilla.org/r/189958/#review195200
Attachment #8919043 -
Flags: review?(jwwang) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919044 [details]
Bug 1409178 - Move DecoderTraits::CreateDecoder() to ChannelMediaDecoder::Create().
https://reviewboard.mozilla.org/r/189960/#review195202
Attachment #8919044 -
Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d12abe3c6409
Remove MediaDecoder::InitStatics() since it's a no-op. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/0209054b0c1a
Merge InstantiateDecoder and DecoderTraits::CreateDecoder. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/9fe2c17be333
Move DecoderTraits::CreateDecoder() to ChannelMediaDecoder::Create(). r=jwwang
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d12abe3c6409
https://hg.mozilla.org/mozilla-central/rev/0209054b0c1a
https://hg.mozilla.org/mozilla-central/rev/9fe2c17be333
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•