Closed
Bug 1409284
Opened 7 years ago
Closed 7 years ago
js::atomics_wait: unnecessary parentheses in declaration of 'addr'
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
root@irill4:~/firefox-gcc-last# /root/firefox-gcc-last/js/src/builtin/AtomicsObject.cpp:790:24: error: unnecessary parentheses in declaration of 'addr' [-Werror=parentheses]
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919181 [details]
Bug 1409284 - js::atomics_wait: Remove unnecessary parentheses in declaration of 'addr'
https://reviewboard.mozilla.org/r/190096/#review195362
Looks good with one nit addressed, thanks, this confused me in the place (it made SharedMem look like a function that returns a mutable ref).
::: js/src/builtin/AtomicsObject.cpp:790
(Diff revision 1)
>
> // This lock also protects the "waiters" field on SharedArrayRawBuffer,
> // and it provides the necessary memory fence.
> AutoLockFutexAPI lock;
>
> - SharedMem<int32_t*>(addr) = view->viewDataShared().cast<int32_t*>() + offset;
> + SharedMem<int32_t*>addr = view->viewDataShared().cast<int32_t*>() + offset;
nit: add space between `>` and `addr`
Attachment #8919181 -
Flags: review?(bbouvier) → review+
| Comment hidden (mozreview-request) |
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0108b7aec940
js::atomics_wait: Remove unnecessary parentheses in declaration of 'addr' r=bbouvier
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•