Closed
Bug 1409323
Opened 7 years ago
Closed 7 years ago
Allow to register new addon scalars for an existing category
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
Attachments
(1 file)
As shown in bug 1408975 comment 8, we have a problem with the addon scalar API: if we register scalar A and then try to register again scalars A and B together, scalar B won't get registered because scalar A was already registered.
We should fix that by changing [1] to skip existing scalars but register new ones.
[1] - http://searchfox.org/mozilla-central/rev/a984558fa2bbde6492d3fb918496fc0b0835b2ce/toolkit/components/telemetry/TelemetryScalar.cpp#1395
Assignee | ||
Updated•7 years ago
|
Comment 1•7 years ago
|
||
We should fix this for 58, which still has about a month left on Nightly.
Priority: P1 → P2
Assignee | ||
Updated•7 years ago
|
Priority: P2 → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8925866 [details]
Bug 1409323 - Allow to register new addon scalars for an existing category.
https://reviewboard.mozilla.org/r/197066/#review202256
One nit
::: toolkit/components/telemetry/TelemetryScalar.cpp:2749
(Diff revision 1)
> }
>
> /**
> * This adds the dynamic scalar definitions coming from
> - * the parent process to this child process.
> + * the parent process to this child process. If a dynamic
> + * scalar definition is already, check if the new definition
"If a dynamic scalar definition is already" think you want the word "defined" in there after "already"
Attachment #8925866 -
Flags: review?(chutten) → review+
Comment hidden (mozreview-request) |
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/93469c0e79b6
Allow to register new addon scalars for an existing category. r=chutten
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•