Sylvestre Ledru [:Sylvestre] Reporter
	Description • 7 years ago

In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/memory/build/Unified_cpp_memory_build0.cpp:2:0:
 /root/firefox-gcc-last/memory/build/mozjemalloc.cpp: In member function 'void** AddressRadixTree<Bits>::GetSlot(void*, bool)':
 /root/firefox-gcc-last/memory/build/mozjemalloc.cpp:1695:10: error: address of local variable 'node' returned [-Werror=return-local-addr]
    void** node;
           ^~~~
 cc1plus: all warnings being treated as errors


With gcc 8 trunk

	Sylvestre Ledru [:Sylvestre] Reporter
	Comment 1 • 7 years ago

Glandium, is that a false positive?
Thanks

	Eric Rahm [:erahm]
	Comment 2 • 7 years ago

(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> Glandium, is that a false positive?
> Thanks

I think it's just getting tripped up by the `&node[subkey]` [1] notation. `node` itself points to somewhere in `mRoot` [2].

[1] http://searchfox.org/mozilla-central/rev/a984558fa2bbde6492d3fb918496fc0b0835b2ce/memory/build/mozjemalloc.cpp#1721
[2] http://searchfox.org/mozilla-central/rev/a984558fa2bbde6492d3fb918496fc0b0835b2ce/memory/build/mozjemalloc.cpp#1698

	Mike Hommey [:glandium]
	Comment 3 • 7 years ago

Seems like a bug in GCC trunk.