Closed
Bug 1409545
Opened 7 years ago
Closed 7 years ago
Interceptor should resolve IUnknown outparams to expected interface when possible
Categories
(Core :: IPC: MSCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
(Whiteboard: aes+)
Attachments
(1 file)
|
(deleted),
patch
|
jimm
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
If we have an interface that declares a method with IUnknown outparams, we should have a way to convert that IUnknown to the interface that is eventually expected by the handler.
Currently we get a mismatch and the handler gets confused.
|
Assignee | |
Comment 1•7 years ago
|
||
If there is a handler provider and we encounter an IUnknown outparam, we query the provider for the expected IID.
Attachment #8919478 -
Flags: review?(jmathies)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8919478 [details] [diff] [review]
Fix
Review of attachment 8919478 [details] [diff] [review]:
-----------------------------------------------------------------
sorry for the delay. lgtm.
Attachment #8919478 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e18338742e1718582409afba8c0b5e7a633137ff
Bug 1409545: Add the ability to query a handler provider for the expected interface for an IUnknown outparam; r=jimm
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
status-firefox57:
--- → affected
Comment on attachment 8919478 [details] [diff] [review]
Fix
This fix is also needed to fix bug 1406822
Attachment #8919478 -
Flags: approval-mozilla-beta+
|
||
Comment 6•7 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•