Closed
Bug 1409771
Opened 7 years ago
Closed 7 years ago
promiseBookmarksNotification doesn't handle skipDescendantsOnItemRemoval/skipTags in the observer it creates
Categories
(Firefox :: Bookmarks & History, enhancement, P3)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
Looking into bug 1409069, I noticed some errors being dumped out:
promiseBookmarksNotification: got skipDescendantsOnItemRemoval notification
Since skipDescendantsOnItemRemoval isn't an actual notification, but a value for observers to specify, we should really be handling it properly, not as a notification.
|
Assignee | |
Updated•7 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [fxsearch]
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919808 [details]
Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.
https://reviewboard.mozilla.org/r/190736/#review195910
This is ok, even if we should really throw this away and use PlacesTestUtils.waitForNotification
Attachment #8919808 -
Flags: review?(mak77) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8919808 [details]
Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.
Lets just switch to waitForNotification and get it done whilst we're here.
Attachment #8919808 -
Flags: review+ → review?(mak77)
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919808 [details]
Bug 1409771 - Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly.
https://reviewboard.mozilla.org/r/190736/#review196672
I love to see code going away!
Attachment #8919808 -
Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cea95605332
Switch tests from promiseBookmarksNotification to PlacesTestUtils.waitForNotification so that skipDescendantsOnItemRemoval/skipTags are handled correctly. r=mak
|
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•