Closed
Bug 1409839
Opened 7 years ago
Closed 7 years ago
Ship more than one built-in message theme
Categories
(Thunderbird :: Instant Messaging, enhancement)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 58.0
People
(Reporter: florian, Assigned: florian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
Instantbird has a few good built-in themes, we should ship them in Thunderbird too.
|
Assignee | |
Comment 1•7 years ago
|
||
This ships the Instantbird themes, and renames the current Thunderbird theme to "mail".
I think this won't break Instantbird (unless someone has the bad idea to install a message theme called 'mail' or set that pref value in about:config, as Instantbird doesn't ship a 'mail' message theme).
Attachment #8919869 -
Flags: review?(clokep)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
Attachment #8919869 -
Flags: review?(clokep) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/comm-central/rev/1f4f67757e3f
Ship more than one built-in message theme, r=clokep.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Comment 3•7 years ago
|
||
I backed that out:
https://hg.mozilla.org/comm-central/rev/8c8f470eb28a8f49a44ed6546d95e16b19170824
Backed out changeset 1f4f67757e3f (bug 1409839) for causing duplicate files and breaking the build. a=jorgk
Please do a try build before pushing this again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 4•7 years ago
|
||
Hey Florian, wasn't there a misspelled variant of Bubbles or something? I can't find a bug about this, but now would be a good time to rename this.
Pushed by florian@queze.net:
https://hg.mozilla.org/comm-central/rev/48a9e9661d7c
Ship more than one built-in message theme, r=clokep.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•7 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #3)
> I backed that out:
> https://hg.mozilla.org/comm-central/rev/
> 8c8f470eb28a8f49a44ed6546d95e16b19170824
> Backed out changeset 1f4f67757e3f (bug 1409839) for causing duplicate files
> and breaking the build. a=jorgk
>
> Please do a try build before pushing this again.
Sorry about that. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e2de144c9ed7e3aebcd8574e56ab18c3c68e2527 doesn't look more colorful than comm-central so I just pushed it again.
(In reply to Patrick Cloke [:clokep] from comment #4)
> Hey Florian, wasn't there a misspelled variant of Bubbles or something? I
> can't find a bug about this, but now would be a good time to rename this.
Good idea, I fixed that typo before pushing again. For reference, the Instantbird bug you remembered was bug 954307.
|
|
||
Comment 7•7 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-
> central&revision=e2de144c9ed7e3aebcd8574e56ab18c3c68e2527 doesn't look more
> colorful than comm-central so I just pushed it again.
I'm working on getting all those failures resolved, sadly very slow going as far as two M-C regressions are concerned which are outside my control: Bug 1404577 and bug 1399746.
Collection of test failures here: https://mzl.la/2gS72WO
|
|
||
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 58.0
You need to log in
before you can comment on or make changes to this bug.
Description
•