Gahh... I just wrote quite a long commentary on one patch using edit attachment / Edit Attachment as bug. After clicking submit it said that I don't have the permissions to edit attachments. True, but it could've told me that without giving me that textarea to waste my time on. ;-) Now I had to copy-paste the patch and write down my comments as a normal patch comment. An alternative fix might be to allow posting attachment-comments with the same privs as posting comments.

See what I did in bug 97729. When the editattachment screen is redone, then we probably should allow commenting, but this does depend on teh rewrite. So I'm going to morph this bug a bit (OK, a lot...), to the RFE that users withouth edit perms should be able to add comments.

Ok, that's fine with me. The RFE you morphed this into is a much better alternative, but I was aiming for the lowest-effort fix, because this bug causes user-wise data loss (as once user submits the form, there seems to be no way to get back the comments - pressing back also reverts the "edit attachment as comment"-mode at least in Mozilla - a lot of work can be lost easily).

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being retargeted to 2.20 If you plan to act on one immediately, go ahead and pull it back to 2.18.

This bug has not been touched by its owner in over six months, even though it is targeted to 2.20, for which the freeze is 10 days away. Unsetting the target milestone, on the assumption that nobody is actually working on it or has any plans to soon. If you are the owner, and you plan to work on the bug, please give it a real target milestone. If you are the owner, and you do *not* plan to work on it, please reassign it to nobody@bugzilla.org or a .bugs component owner. If you are *anybody*, and you get this comment, and *you* plan to work on the bug, please reassign it to yourself if you have the ability.

We should make attachment attribute fields non editable for users without required privileges to edit them, but that's another bug.

r=a=me as module owner.

Checking in attachment.cgi; /cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v <-- attachment.cgi new revision: 1.160; previous revision: 1.159 done Checking in Bugzilla/Attachment.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v <-- Attachment.pm new revision: 1.66; previous revision: 1.65 done

Added to the release notes in bug 547466.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/qa/4.0/ modified t/test_private_attachments.t Committed revision 177. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/qa/3.6/ modified t/test_private_attachments.t Committed revision 148.