Closed Bug 1410338 Opened 7 years ago Closed 7 years ago

[Photon] Incorrect color for History Panel message

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
ARM
Android
Type:
defect

Tracking

(fennec+, firefox56 unaffected, firefox57 verified, firefox58 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
fennec + ---
firefox56 --- unaffected
firefox57 --- verified
firefox58 --- verified

People

(Reporter: sflorean, Assigned: cnevinchen)

References

Details

(Whiteboard: [FNC][SPT58.3][INT])

Attachments

(2 files)

Screenshot_20171020-112834.png
(deleted), image/png
Details
Bug 1410338 - Incorrect color for History Panel message.
(deleted), text/x-review-board-request
cnevinchen
: review+
ritu
: approval-mozilla-beta+
Details
Attached image Screenshot_20171020-112834.png (deleted) —
Environment: Device: Samsung Galaxy Tab 3 (Android 7.0); Build: Nightly 58.0a1 (2017-10-17); Steps to reproduce: 1. Launch fennec with a clean profile; 2. Go to History panel; Expected result: "Psst: using a New Private Tab won't save your history" has blue (photon) color. Actual result: "Psst: using a New Private Tab won't save your history" has orange color.
tracking-fennec: --- → ?
Carol, would you help check it? tks.
tracking-fennec: ? → +
Flags: needinfo?(cnevinchen)
Flags: needinfo?(chuang)
Priority: -- → P1
I don't think we have spec for it. I'll let Carol decide the color.
Flags: needinfo?(cnevinchen)
Please change the orange to #0a84ff color. thanks!
Flags: needinfo?(chuang) → needinfo?(cnevinchen)
Comment on attachment 8920936 [details] Bug 1410338 - Incorrect color for History Panel message. https://reviewboard.mozilla.org/r/191880/#review197072
Attachment #8920936 - Flags: review?(cnevinchen) → review+
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e992675a27d Incorrect color for History Panel message. r=nechen
Flags: needinfo?(cnevinchen)
Assignee: nobody → cnevinchen
Comment on attachment 8920936 [details] Bug 1410338 - Incorrect color for History Panel message. Approval Request Comment [Feature/Bug causing the regression]: Align new photon design [User impact if declined]: User will see old color [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]:no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:no [Is the change risky?]:no [Why is the change risky/not risky?]: just change color [String changes made/needed]:no
Attachment #8920936 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/5e992675a27d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified as fixed on Nightly 58 (2017-24-10). Devices: Xiaomi Mi Pad 2 (Android 5.1) Samsung Galaxy Tab 3 (Android 7.0)
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
Comment on attachment 8920936 [details] Bug 1410338 - Incorrect color for History Panel message. Low risk fix for a very visible recent regression, Beta57+
Attachment #8920936 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [FNC][SPT58.3][INT]
Verified as fixed on the 57.0 RC build This issue was tested on a Pixel C (Android 8.0) device
status-firefox57: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: