Closed Bug 1410428 Opened 7 years ago Closed 7 years ago

Handle stales messages in {WebAuthn,U2F}Manager

Categories

(Core :: DOM: Device Interfaces, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

With both managers storing transaction infos in `Maybe<Info> mTransaction` now, it occurred to me that we can't actually assert that `mTransaction.isSome() == true` when we receive a message. At least with the U2F API the request could be cancelled (and mTransaction cleared) while there's a pending completion message. For WebAuthn it probably doesn't hurt to handle this properly either.
Comment on attachment 8920575 [details] Bug 1410428 - Handle stales messages in {WebAuthn,U2F}Manager r=jcj J.C. Jones [:jcj] has approved the revision. https://phabricator.services.mozilla.com/D145#3373
Attachment #8920575 - Flags: review+
Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbb4e9e60ad Handle stales messages in {WebAuthn,U2F}Manager r=jcj
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: