Closed
Bug 1410518
Opened 7 years ago
Closed 7 years ago
Change nsIRDFDataSource URI to ACString
Categories
(Core Graveyard :: RDF, defect)
Core Graveyard
RDF
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I thought this would be useful for bug 1381725 to get rid of some of strdup calls. I am not super used to mozilla string classes, is using SetIsVoid(true) correct?
Attachment #8920690 -
Flags: review?(nfroyd)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → evilpies
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8920690 [details] [diff] [review]
Change nsIRDFDataSource URI to ACString
Review of attachment 8920690 [details] [diff] [review]:
-----------------------------------------------------------------
SetIsVoid() is the correct thing to do here. Thank you for this, this looks great!
Attachment #8920690 -
Flags: review?(nfroyd) → review+
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fecdd6a3f847
Change nsIRDFDataSource URI to ACString. r=froydnj
|
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e5b865a214
Fix typo. r=me
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•