Closed Bug 1410739 Opened 7 years ago Closed 6 years ago

Remove Instantbird code from the repository

Categories

(Instantbird Graveyard :: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 59

People

(Reporter: jorgk-bmo, Unassigned)

Details

Oops, pressed "Submit" too fast. IB code shows up in DXR. Usually when we fix bustage in TB/SM, like in the package manifests or the mainlines, or when removing/replacing features removed in M-C, we handle all three applications TB/IB/SM in the same patch, latest example, bug 1410713. So we need to keep fixing dead code or deprecated/removed M-C features will show up in searches in C-C. Both options are undesirable, so Instantbird code should be (re)moved or at least removed from the DXR index.
Flags: needinfo?(florian)
It should be removed eventually, yes. For exactly the reasons you mentioned. Doing it right now would be unfortunate for at least 2 reasons: - I believe Tor Messenger is still built off of im/ from comm-central - While working on bug 1409891 (and more generally porting code from Instantbird), it's very convenient to have easy access to both the TB and the IB version of a file in searchfox.
Flags: needinfo?(florian)
> I believe Tor Messenger is still built off of im/ from comm-central Don't block on us. We currently build on ESR 52 and will move to the Thunderbird UI at 59. Thanks.
Hi arlolra, thanks for the information. The next ESR changed to v60 (FF and TB), so please plan accordingly.
I will remove im/ next week. It positively doesn't build any more and it is causing great inconvenience when looking through DXR for interfaces that M-C is removing and finding all those "false positives" in im/. Any objections, so speak out now or forever hold your peace.
Flags: needinfo?(florian)
Flags: needinfo?(clokep)
(In reply to Jorg K (GMT+1) from comment #5) > I will remove im/ next week. It positively doesn't build any more and it is > causing great inconvenience when looking through DXR for interfaces that M-C > is removing and finding all those "false positives" in im/. > > Any objections, so speak out now or forever hold your peace. There are still a few UI things that would be easier to port if we could search both mail and im in searchfox at once. (The first example that comes to mind is context menus on IRC nicks found in channels). Can you explain a bit more what you call "great inconvenience"? It sounds a bit exaggerated to me. Anyway, I agree that we should remove it relatively soon. Could we agree to do it by the end of May?
Flags: needinfo?(florian)
(In reply to Florian Quèze [:florian] from comment #6) > Can you explain a bit more what you call "great inconvenience"? It sounds a > bit exaggerated to me. Boris is helping us when it comes to changes in M-C, in particular nsIDOM* removals. He finds many call sites under im/ and I have to remind him that that is dead code. Whether you'd call this mildly, regularly or greatly inconvenient is in the eye of the beholder. I'd prefer for those "false positives" not to appear. > Anyway, I agree that we should remove it relatively soon. Could we agree to > do it by the end of May? OK.
Flags: needinfo?(clokep)
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/d4e700bab1b1 Remove Instantbird code from the repository. r=me DONTBUILD
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 59
You need to log in before you can comment on or make changes to this bug.