Closed Bug 1410929 Opened 7 years ago Closed 7 years ago

fix recursion errors on Rules page

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

It looks like we end up with circular references in some Rule objects after performing some actions. Eg: if I schedule a change, then try to modify that scheduled change, I get an error like: Error: cyclic object value If I print out the object being modified, I find that it has a structure like: { ... "original_row": { ... "scheduled_change": { ... "original_row": {...} } } } I suspect that we're copying in too much data to $scope.rules after creating or modifying something, hence the "original_row" entry.
Looks like there's a recursion error when adding a scheduled change too, but it doesn't result in an error.
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/f91aa6bd87e47cfd80f5d0fd81943991150b0c11 bug 1410929: Don't put original_row into object that gets copied around. (#440). r=jlorenzo
Assignee: nobody → bhearsum
Priority: -- → P1
Depends on: 1411563
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.