Closed
Bug 1411037
Opened 7 years ago
Closed 6 years ago
Disable -Werror on -Wmultistatement-macros
Categories
(Developer Infrastructure :: Source Code Analysis, defect, P3)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
/root/firefox-gcc-last/xpcom/base/nsConsoleService.cpp: In member function 'virtual nsresult nsConsoleService::QueryInterface(const nsIID&, void**)': /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsImpl.h:970:5: error: macro expands to multiple statements [-Werror=multistatement-macros] foundInterface = 0; \ ^~~~~~~~~~~~~~
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Product: Core → Firefox Build System
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8958410 [details] Bug 1411037 - Disable -Werror on -Wmultistatement-macros. Would be a pain to fix all occurrences, for very little gain https://reviewboard.mozilla.org/r/227372/#review233158 Thank you! ::: build/moz.configure/warnings.configure:102 (Diff revision 1) > check_and_add_gcc_warning('-Wno-error=coverage-mismatch', when='MOZ_PGO') > > # false positives depending on optimizations > check_and_add_gcc_warning('-Wno-error=free-nonheap-object') > > +# Would be a pain to fix that in all occurrences for a small gain Nit: I'd word this as "Would be a pain to fix all occurrences, for very little gain."
Attachment #8958410 -
Flags: review?(nfroyd) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sledru
Summary: Fix the -Wmultistatement-macros in xpcom/base → Disable -Werror on -Wmultistatement-macros
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8861684c3209 Disable -Werror on -Wmultistatement-macros. Would be a pain to fix all occurrences, for very little gain r=froydnj
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8861684c3209
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
status-firefox58:
affected → ---
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•