Closed
Bug 1411248
Opened 7 years ago
Closed 7 years ago
Avoid partial display list building in cases where it is almost certainly slower than a full rebuild
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: mikokm, Assigned: mikokm)
References
Details
Attachments
(1 file)
Follow-up to bug 1404181.
Assignee | ||
Comment 1•7 years ago
|
||
With retained display lists, we keep a list of frames that have been modified between the paints. If this list contains certain types of frames such as canvas (large display port area) or scrollbar frames (different async AGR), we almost certainly end up rebuilding the whole display list again. This combined with display list preprocessing and merging overhead will make us slower than just doing a full rebuild.
Hopefully we can address these cases later.
This patch also adds a pref that can be used to set the upper bound for modified frames before a full rebuild is done. The default value 500 was selected based on empirical testing (Amazon/Facebook/Youtube on MBP).
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8921455 [details]
Bug 1411248 - Add some early exit heuristics to avoid complicated partial display list builds
https://reviewboard.mozilla.org/r/192500/#review197734
Attachment #8921455 -
Flags: review?(matt.woodrow) → review+
Comment 4•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 29ae88c75c65 -d cb757b237396: rebasing 429444:29ae88c75c65 "Bug 1411248 - Add some early exit heuristics to avoid complicated partial display list builds r=mattwoodrow" (tip)
merging gfx/thebes/gfxPrefs.h
merging modules/libpref/init/all.js
warning: conflicts while merging gfx/thebes/gfxPrefs.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2ecebc7f1475
Add some early exit heuristics to avoid complicated partial display list builds r=mattwoodrow
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•