Closed
Bug 1411529
Opened 7 years ago
Closed 7 years ago
Context menu functionality in GeckoView based components not working.
Categories
(GeckoView :: General, defect, P1)
Tracking
(firefox58 verified)
VERIFIED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | verified |
People
(Reporter: cnevinchen, Assigned: droeh)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
I can't get callback in GeckoView-based components like Custom Tab[1] and PWA[2].
[1] http://searchfox.org/mozilla-central/rev/1285ae3e810e2dbf2652c49ee539e3199fcfe820/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java#659
[2] http://searchfox.org/mozilla-central/rev/1285ae3e810e2dbf2652c49ee539e3199fcfe820/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java#95
Previously(Bug 1365868 and Bug 1409296) it worked.
|
Reporter | |
Comment 1•7 years ago
|
||
Please help advise:)
Flags: needinfo?(wehuang)
Flags: needinfo?(droeh)
|
||
Updated•7 years ago
|
|
|
||
Comment 2•7 years ago
|
||
Snorp, Dylan, this is the follow-up of bug 1409296 and should start with P1, and assume Dylan would be the one to resume the investigation here? Thanks.
Flags: needinfo?(wehuang) → needinfo?(snorp)
Yeah, Dylan, please see if you can figure out what's going on with this.
Assignee: nobody → droeh
Flags: needinfo?(snorp)
|
Assignee | |
Comment 4•7 years ago
|
||
Yeah, I'm looking at this right now. It looks like maybe text selection is taking precedence over the context menu for some reason?
Flags: needinfo?(droeh)
|
|
Assignee | |
Comment 5•7 years ago
|
||
It looks like the culprit is bug 1406224; Eugen's patch for context menu support (bug 1381983) uses nsIDOMHTMLImageElement, which is now removed.
|
|
Assignee | |
Comment 6•7 years ago
|
||
This updates GeckoViewContent.js to avoid using nsIDOMHTMLImageElement (as well as nsIDOMHTMLMediaElement, which appears to be on the chopping block in bug 1407040); this should fix the issue.
Attachment #8921959 -
Flags: review?(snorp)
Attachment #8921959 -
Flags: review?(snorp) → review+
|
||
Updated•7 years ago
|
Target Milestone: --- → Firefox 58
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63b2340d7000
Remove nsIDOMHTMLImageElement usage from GeckoViewContent.js r=snorp
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
|
||
Comment 9•7 years ago
|
||
Verified as fixed in Nightly 58 (2017-10-26). The simplified context menu is working again.
Status: RESOLVED → VERIFIED
|
|
||
Comment 10•7 years ago
|
||
> getClassName(node) === "HTMLMediaElement"
This never tests true, because HTMLMediaElement is abstract; the concrete classes are HTMLVideoElement and HTMLAudioElement. (Spotted by :adrian17.)
Flags: needinfo?(droeh)
|
|
Assignee | |
Comment 11•7 years ago
|
||
Thanks for catching that! Filed as bug 1438342.
Flags: needinfo?(droeh)
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Keywords: regressionwindow-wanted
Target Milestone: Firefox 58 → mozilla58
|
|
||
Updated•6 years ago
|
Keywords: regressionwindow-wanted
|
||
Comment 12•2 years ago
|
||
Removing regressionwindow-wanted keyword because this bug has been resolved.
Keywords: regressionwindow-wanted
|
|
||
Comment 13•2 years ago
|
||
Removing regressionwindow-wanted keyword because this bug has been resolved.
|
|
||
Comment 14•2 years ago
|
||
Removing regressionwindow-wanted keyword because this bug has been resolved.
You need to log in
before you can comment on or make changes to this bug.
Description
•