Sylvestre Ledru [:Sylvestre] Assignee
	Description • 7 years ago

/root/firefox-gcc-last/js/src/wasm/WasmJS.cpp: In member function 'virtual void CompileStreamTask::streamClosed(JS::StreamConsumer::CloseReason)':
 /root/firefox-gcc-last/js/src/wasm/WasmJS.cpp:2315:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
              }
              ^

	Luke Wagner [:luke]
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8921840 [details]
Bug 1411545 - streamClosed: Fix the implicit-fallthrough warning

https://reviewboard.mozilla.org/r/192878/#review198148

::: js/src/wasm/WasmJS.cpp:2316
(Diff revision 1)
>                  setClosedAndDestroyAfterHelperThreadStarted();
>                  return;
>                case Closed:
>                  MOZ_CRASH("streamClosed() in Closed state");
>              }
> +            break;

Ah, didn't know about this warning.  Thanks for the patch!  For symmetry, could you add a 'break' below at the end of the Error case too?

	Pulsebot
	Comment 4 • 7 years ago

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7bd525a3831
streamClosed: Fix the implicit-fallthrough warning r=luke

	Attila Craciun [:arny]
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d7bd525a3831